Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix AttributeError in summing of number of tests in GroupingFormatter #18720

Closed
wants to merge 1 commit into from
Closed

fix AttributeError in summing of number of tests in GroupingFormatter #18720

wants to merge 1 commit into from

Conversation

@gterzian
Copy link
Member

gterzian commented Oct 3, 2017 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #18708 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@gterzian
fix AttributeError in summing of number of tests in GroupingFormatter
Loading status checks…
a0a28ee
@highfive
Copy link

highfive commented Oct 3, 2017

Heads up! This PR modifies the following files:

  • @jgraham: tests/wpt/grouping_formatter.py
@jdm
Copy link
Member

jdm commented Oct 3, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

📌 Commit a0a28ee has been approved by jdm
@highfive highfive assigned jdm and unassigned asajeffrey Oct 3, 2017
@jdm
Copy link
Member

jdm commented Oct 3, 2017

Closing in favour of #18724 which gives us actual test counts.
@jdm jdm closed this Oct 3, 2017
@gterzian gterzian deleted the gterzian:fix_grouping_formatter branch Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

WPT tests runner Python error
5 participants
@gterzian @highfive @jdm @bors-servo @asajeffrey
You can’t perform that action at this time.