Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Implement Element.matches using stylo. #18721

Merged
merged 2 commits into from Oct 3, 2017
Merged

stylo: Implement Element.matches using stylo. #18721

merged 2 commits into from Oct 3, 2017

Conversation

@emilio
Copy link
Member

emilio commented Oct 3, 2017 •
edited by SimonSapin

From bug 1404897.

This change is Reviewable
@highfive
Copy link

highfive commented Oct 3, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/sugar/ownership.rs, ports/geckolib/glue.rs
  • @canaltinova: components/style/gecko_bindings/sugar/ownership.rs
@highfive
Copy link

highfive commented Oct 3, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Oct 3, 2017

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

📌 Commit e805106 has been approved by heycam
@highfive highfive assigned heycam and unassigned wafflespeanut Oct 3, 2017
emilio added 2 commits Oct 2, 2017
@emilio
stylo: Add bindings to Servo selector lists.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
c65e7d6 
Bug: 1404897
Reviewed-by: heycam
MozReview-Commit-ID: 4ZrWawDwuNe
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@emilio
stylo: Implement Element.matches using stylo.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
6fc967f 
Bug: 1404897
Reviewed-by: heycam
MozReview-Commit-ID: 7nxYVcweu0W
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@emilio emilio force-pushed the emilio:matches-stylo branch from b287d28 to 6fc967f Oct 3, 2017
@emilio
Copy link
Member Author

emilio commented Oct 3, 2017

@bors-servo r=heycam p =1
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

📌 Commit 6fc967f has been approved by heycam
@emilio
Copy link
Member Author

emilio commented Oct 3, 2017

@bors-servo p=1
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit 6fc967f with merge 31cef8c...
bors-servo added a commit that referenced this pull request Oct 3, 2017
@bors-servo
Auto merge of #18721 - emilio:matches-stylo, r=heycam
Loading status checks…
31cef8c 
 stylo: Implement Element.matches using stylo.

From bug 1404897.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18721)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Oct 3, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing 31cef8c to master...
@bors-servo bors-servo merged commit 6fc967f into servo:master Oct 3, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@emilio @highfive @bors-servo @jdm @heycam @wafflespeanut
You can’t perform that action at this time.