Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Use a SharedFontList object to store font-family values for Gecko #18722

Merged
merged 2 commits into from Oct 4, 2017
Merged

style: Use a SharedFontList object to store font-family values for Gecko #18722

merged 2 commits into from Oct 4, 2017

Conversation

@heycam
Copy link
Member

heycam commented Oct 3, 2017 •
edited by SimonSapin

Reviewed by Xidorn and Manish in https://bugzilla.mozilla.org/show_bug.cgi?id=1397626.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Oct 3, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/properties/longhand/font.mako.rs, components/style/gecko_bindings/sugar/refptr.rs
  • @canaltinova: components/style/properties/gecko.mako.rs, components/style/properties/longhand/font.mako.rs, components/style/gecko_bindings/sugar/refptr.rs
  • @KiChjang: components/script/dom/element.rs
  • @fitzgen: components/script/dom/element.rs
  • @emilio: components/style/properties/gecko.mako.rs, components/style/properties/longhand/font.mako.rs, components/style/gecko_bindings/sugar/refptr.rs
@highfive
Copy link

highfive commented Oct 3, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style, gfx, and script code, but no tests are modified. Please consider adding a test!
@heycam
Copy link
Member Author

heycam commented Oct 3, 2017

@bors-servo r=upsuper
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

📌 Commit b8ab7c8 has been approved by upsuper
@highfive highfive assigned upsuper and unassigned emilio Oct 3, 2017
@heycam
Copy link
Member Author

heycam commented Oct 3, 2017

@bors-servo p=1
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit b8ab7c8 with merge 1a46be8...
bors-servo added a commit that referenced this pull request Oct 3, 2017
@bors-servo
Auto merge of #18722 - heycam:family-list, r=upsuper
Loading status checks…
1a46be8 
style: Use a SharedFontList object to store font-family values for Gecko

Reviewed by Xidorn and Manish in https://bugzilla.mozilla.org/show_bug.cgi?id=1397626.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18722)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

💔 Test failed - linux-dev
@jdm
Copy link
Member

jdm commented Oct 3, 2017 

---- specified_values::size_of_specified_values stdout ----
	thread 'specified_values::size_of_specified_values' panicked at 'Your changes have decreased the size of font_family SpecifiedValue to 16. Good work! The threshold is currently 24. Please consider removing `boxed="True"` from this longhand.', /home/servo/buildbot/slave/linux-dev/build/tests/unit/stylo/specified_values.rs:48
heycam added 2 commits Sep 29, 2017
@heycam
style: Use a SharedFontList object to store font-family values for Ge…
4d9dd4b 
…cko.
@heycam
style: Regenerate Gecko bindings.
Loading status checks…
fde77ee
@heycam heycam force-pushed the heycam:family-list branch from b8ab7c8 to fde77ee Oct 4, 2017
@heycam
Copy link
Member Author

heycam commented Oct 4, 2017

@bors-servo r=upsuper
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

📌 Commit fde77ee has been approved by upsuper
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

⌛ Testing commit fde77ee with merge 9f09c26...
bors-servo added a commit that referenced this pull request Oct 4, 2017
@bors-servo
Auto merge of #18722 - heycam:family-list, r=upsuper
Loading status checks…
9f09c26 
style: Use a SharedFontList object to store font-family values for Gecko

Reviewed by Xidorn and Manish in https://bugzilla.mozilla.org/show_bug.cgi?id=1397626.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18722)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

💔 Test failed - windows-msvc-dev
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

💔 Test failed - windows-msvc-dev
@upsuper
Copy link
Member

upsuper commented Oct 4, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

⌛ Testing commit fde77ee with merge 8ba39d0de0d68ff2a4a7a876a293e67c8c23f7c4...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

💔 Test failed - windows-msvc-dev
@upsuper
Copy link
Member

upsuper commented Oct 4, 2017

@bors-servo try
1 similar comment
@upsuper
Copy link
Member

upsuper commented Oct 4, 2017

@bors-servo try
@jdm
Copy link
Member

jdm commented Oct 4, 2017

@bors-servo: retry

  • shut down the faulty windows builder
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

⌛ Trying commit fde77ee with merge 1e3bf67...
bors-servo added a commit that referenced this pull request Oct 4, 2017
@bors-servo
Auto merge of #18722 - heycam:family-list, r=<try>
Loading status checks…
1e3bf67 
style: Use a SharedFontList object to store font-family values for Gecko

Reviewed by Xidorn and Manish in https://bugzilla.mozilla.org/show_bug.cgi?id=1397626.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18722)
<!-- Reviewable:end -->
@heycam
Copy link
Member Author

heycam commented Oct 4, 2017

@bors-servo r=upsuper
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

📌 Commit fde77ee has been approved by upsuper
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

⌛ Testing commit fde77ee with merge 3b7a82b...
bors-servo added a commit that referenced this pull request Oct 4, 2017
@bors-servo
Auto merge of #18722 - heycam:family-list, r=upsuper
Loading status checks…
3b7a82b 
style: Use a SharedFontList object to store font-family values for Gecko

Reviewed by Xidorn and Manish in https://bugzilla.mozilla.org/show_bug.cgi?id=1397626.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18722)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: upsuper
Pushing 3b7a82b to master...
@bors-servo bors-servo merged commit fde77ee into servo:master Oct 4, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 4, 2017
Merged
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@upsuper upsuper

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@heycam @highfive @bors-servo @jdm @upsuper @emilio
You can’t perform that action at this time.