Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix the test count in the WPT grouping_formatter #18724
Conversation
The internal WPT API seems to have changed again, so we must revert the previous change here to get the correct test count.
highfive
commented
Oct 3, 2017
|
Heads up! This PR modifies the following files:
|
|
@bors-servo: r+ |
|
|
Fix the test count in the WPT grouping_formatter The internal WPT API seems to have changed again, so we must revert the previous change here to get the correct test count. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because this is a change to the test harness runner script. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18724) <!-- Reviewable:end -->
|
|
|
|
|
|
|
@bors-servo retry infra |
|
|
|
|
|
@bors-servo retry infra |
|
|
|
|
|
@bors-servo retry
|
|
|
|
|
|
@bors-servo retry
|
Fix the test count in the WPT grouping_formatter The internal WPT API seems to have changed again, so we must revert the previous change here to get the correct test count. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because this is a change to the test harness runner script. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18724) <!-- Reviewable:end -->
|
|
mrobinson commentedOct 3, 2017
•
edited by SimonSapin
The internal WPT API seems to have changed again, so we must revert the
previous change here to get the correct test count.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is