Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTickAnimations should create a display list #18725
Conversation
highfive
commented
Oct 3, 2017
|
@mrobinson Is it possible to create an automated test for this? |
|
@jdm The failures seem to happen when TickAnimations is triggered when there is no display list, which so far looks like a timing issue. I will dig in a bit to see if I can reproduce this situation reliably. |
|
@jdm I'm not sure there is an easy way to create an automated test for this issue specifically. The problem seems to trigger intermittently and it's unclear exactly when TickAnimations can trigger before the first display list construction. |
|
@bors-servo: r+ |
|
|
|
@bors-servo: p=10 |
TickAnimations should create a display list This is a regression from the removal of ReflowQueryType. Fixes #18701. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #18701 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because this should fix tests currently failing on the build infrastructure, but the failures seem to be very timing dependent. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18725) <!-- Reviewable:end -->
|
|
mrobinson commentedOct 3, 2017
•
edited by SimonSapin
This is a regression from the removal of ReflowQueryType.
Fixes #18701.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is