Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #18668 - Add mprotect diagnostics for HashMap crash #18732

Merged
merged 1 commit into from Oct 3, 2017
Merged

Revert #18668 - Add mprotect diagnostics for HashMap crash #18732

merged 1 commit into from Oct 3, 2017

Conversation

@bholley
Copy link
Contributor

bholley commented Oct 3, 2017 •
edited by SimonSapin

These diagnostics have served their purpose, time to remove them.

https://bugzilla.mozilla.org/show_bug.cgi?id=1403397

This change is Reviewable
@highfive
Copy link

highfive commented Oct 3, 2017

Heads up! This PR modifies the following files:

  • @canaltinova: components/style/hash.rs, components/style/gecko/generated/bindings.rs, components/style/selector_parser.rs, components/style/selector_map.rs, components/style/invalidation/element/invalidation_map.rs and 1 more
  • @emilio: components/style/hash.rs, ports/geckolib/glue.rs, ports/geckolib/Cargo.toml, components/style/gecko/generated/bindings.rs, components/style/selector_parser.rs and 4 more
@bholley
Copy link
Contributor Author

bholley commented Oct 3, 2017

@bors-servo r+ p=5
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

📌 Commit 0fc5df7 has been approved by bholley
@highfive highfive assigned bholley and unassigned asajeffrey Oct 3, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit 0fc5df7 with merge b75ace1...
bors-servo added a commit that referenced this pull request Oct 3, 2017
@bors-servo
Auto merge of #18732 - bholley:revert_mprotect_diagnostics, r=bholley
Loading status checks…
b75ace1 
Revert #18668 - Add mprotect diagnostics for HashMap crash.

These diagnostics have served their purpose, time to remove them.

https://bugzilla.mozilla.org/show_bug.cgi?id=1403397

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18732)
<!-- Reviewable:end -->
@bholley
Copy link
Contributor Author

bholley commented Oct 3, 2017

@bors-servo r-
@bholley bholley force-pushed the bholley:revert_mprotect_diagnostics branch from 0fc5df7 to d3b9d0d Oct 3, 2017
@bholley
Copy link
Contributor Author

bholley commented Oct 3, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

📌 Commit d3b9d0d has been approved by bholley
@bholley bholley changed the title Revert #18668 - Add mprotect diagnostics for HashMap crash. Revert #18668 - Add mprotect diagnostics for HashMap crash (except for round-up-to-page behavior). Oct 3, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit d3b9d0d with merge 123301b...
bors-servo added a commit that referenced this pull request Oct 3, 2017
@bors-servo
Auto merge of #18732 - bholley:revert_mprotect_diagnostics, r=bholley
Loading status checks…
123301b 
Revert #18668 - Add mprotect diagnostics for HashMap crash (except for round-up-to-page behavior).

These diagnostics have served their purpose, time to remove them.

https://bugzilla.mozilla.org/show_bug.cgi?id=1403397

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18732)
<!-- Reviewable:end -->
@bholley bholley force-pushed the bholley:revert_mprotect_diagnostics branch from d3b9d0d to af0bed9 Oct 3, 2017
@bholley
Copy link
Contributor Author

bholley commented Oct 3, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

📌 Commit af0bed9 has been approved by bholley
@bholley
Copy link
Contributor Author

bholley commented Oct 3, 2017

@bors-servo r+ force
@bholley
Copy link
Contributor Author

bholley commented Oct 3, 2017

@bors-servo retry force
@bholley
Copy link
Contributor Author

bholley commented Oct 3, 2017

@bors-servo retry
@bholley
Copy link
Contributor Author

bholley commented Oct 3, 2017

@bors-servo r+ force
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

📌 Commit f457bf6 has been approved by bholley
@bholley
Copy link
Contributor Author

bholley commented Oct 3, 2017

@bors-servo force
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit f457bf6 with merge 41ca1b75461e523272b9c51e58d38e41c1e6160a...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

💔 Test failed - windows-msvc-dev
@bholley
Revert #18668 - Add mprotect diagnostics for HashMap crash
Loading status checks…
15b866d
@bholley bholley force-pushed the bholley:revert_mprotect_diagnostics branch from f457bf6 to 15b866d Oct 3, 2017
@bholley
Copy link
Contributor Author

bholley commented Oct 3, 2017

@bors-servo r+ force
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

📌 Commit 15b866d has been approved by bholley
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit 15b866d with merge 0b69887...
bors-servo added a commit that referenced this pull request Oct 3, 2017
@bors-servo
Auto merge of #18732 - bholley:revert_mprotect_diagnostics, r=bholley
Loading status checks…
0b69887 
Revert #18668 - Add mprotect diagnostics for HashMap crash (except for round-up-to-page behavior).

These diagnostics have served their purpose, time to remove them.

https://bugzilla.mozilla.org/show_bug.cgi?id=1403397

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18732)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request Oct 3, 2017
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: bholley
Pushing 0b69887 to master...
@bors-servo bors-servo merged commit 15b866d into servo:master Oct 3, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bholley bholley changed the title Revert #18668 - Add mprotect diagnostics for HashMap crash (except for round-up-to-page behavior). Revert #18668 - Add mprotect diagnostics for HashMap crash Oct 3, 2017
@upsuper upsuper mentioned this pull request Oct 4, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bholley bholley

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@bholley @highfive @bors-servo @asajeffrey
You can’t perform that action at this time.