servo / servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: `all` shorthand should not apply to internal properties #18734

Merged

bors-servo merged 1 commit into servo:master from Manishearth:stylo-all

Oct 5, 2017

Member

Manishearth commented Oct 3, 2017 •

edited by SimonSapin

r=xidorn https://bugzilla.mozilla.org/show_bug.cgi?id=1404057

This change is

highfive assigned cbrewster

highfive commented Oct 3, 2017

Heads up! This PR modifies the following files:

@bholley: components/style/properties/properties.mako.rs
@canaltinova: components/style/properties/properties.mako.rs
@emilio: components/style/properties/properties.mako.rs

highfive added the S-awaiting-review label

highfive commented Oct 3, 2017

Warning

These commits modify style code, but no tests are modified. Please consider adding a test!

Member Author

Manishearth commented Oct 3, 2017

@bors-servo r=upsuper

Contributor

bors-servo commented Oct 3, 2017

📌 Commit d4c491a has been approved by upsuper

highfive assigned upsuper and unassigned cbrewster

highfive added S-awaiting-merge and removed S-awaiting-review labels

Contributor

bors-servo commented Oct 4, 2017

⌛ Testing commit d4c491a with merge acd8c52bcc6bdbe1498dead4208ebdc09b54e2a8...

Contributor

bors-servo commented Oct 4, 2017

💔 Test failed - windows-msvc-dev

highfive added S-tests-failed and removed S-awaiting-merge labels

Member Author

Manishearth commented Oct 4, 2017

@bors-servo retry

infra

Contributor

bors-servo commented Oct 4, 2017

⌛ Testing commit d4c491a with merge 950a276775545fca485b7e1630c32ecd839dda8d...

highfive added S-awaiting-merge and removed S-tests-failed labels

Contributor

bors-servo commented Oct 4, 2017

💔 Test failed - windows-msvc-dev

highfive added S-tests-failed and removed S-awaiting-merge labels


        stylo: `all` shorthand should not apply to internal properties

aac31a3

Member

KiChjang commented Oct 4, 2017

@bors-servo retry infra

Contributor

bors-servo commented Oct 4, 2017

⌛ Testing commit d4c491a with merge 7b7a995dcc63057b95d6ee2abbc159e9709fbe77...

highfive added S-awaiting-merge and removed S-tests-failed labels

Contributor

bors-servo commented Oct 4, 2017

💔 Test failed - windows-msvc-dev

highfive added the S-awaiting-merge label

Contributor

bors-servo commented Oct 4, 2017

💔 Test failed - windows-msvc-dev

highfive added S-tests-failed and removed S-awaiting-merge labels

Member Author

Manishearth commented Oct 4, 2017

@bors-servo retry

Contributor

bors-servo commented Oct 4, 2017

⌛ Testing commit aac31a3 with merge cbf9532...

bors-servo added a commit that referenced this pull request


        Auto merge of #18734 - Manishearth:stylo-all, r=upsuper

cbf9532

stylo: `all` shorthand should not apply to internal properties

r=xidorn https://bugzilla.mozilla.org/show_bug.cgi?id=1404057

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18734)
<!-- Reviewable:end -->

highfive added S-awaiting-merge and removed S-tests-failed labels

Contributor

bors-servo commented Oct 4, 2017

💔 Test failed - linux-rel-wpt

highfive added S-tests-failed and removed S-awaiting-merge labels

Member

jdm commented Oct 4, 2017

@bors-servo: retry

Contributor

bors-servo commented Oct 4, 2017

⌛ Testing commit aac31a3 with merge 2684685...

bors-servo added a commit that referenced this pull request


        Auto merge of #18734 - Manishearth:stylo-all, r=upsuper

stylo: `all` shorthand should not apply to internal properties

r=xidorn https://bugzilla.mozilla.org/show_bug.cgi?id=1404057

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18734)
<!-- Reviewable:end -->

highfive added S-awaiting-merge and removed S-tests-failed labels

Contributor

bors-servo commented Oct 4, 2017

💔 Test failed - android

highfive added S-tests-failed and removed S-awaiting-merge labels

Member Author

Manishearth commented Oct 4, 2017

@bors-servo retry

O.o

Contributor

bholley commented Oct 4, 2017

@bors-servo p=1

Contributor

bors-servo commented Oct 5, 2017

⌛ Testing commit aac31a3 with merge 43686a8...

bors-servo added a commit that referenced this pull request


        Auto merge of #18734 - Manishearth:stylo-all, r=upsuper

43686a8

stylo: `all` shorthand should not apply to internal properties

r=xidorn https://bugzilla.mozilla.org/show_bug.cgi?id=1404057

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18734)
<!-- Reviewable:end -->

highfive added S-awaiting-merge and removed S-tests-failed labels

Contributor

bors-servo commented Oct 5, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: upsuper
Pushing 43686a8 to master...

bors-servo merged commit aac31a3 into servo:master

3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded

Details

continuous-integration/travis-ci/pr The Travis CI build passed

Details

homu Test successful

Details

highfive removed the S-awaiting-merge label

Manishearth deleted the Manishearth:stylo-all branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.