Make transforms generic #18750

Manishearth · 2017-10-04T22:59:04Z

This makes the specified and computed value of transform share a generic
backing enum.

This will eventually be a complete fix for
https://bugzilla.mozilla.org/show_bug.cgi?id=1391145 , and also
incidentally fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1405881

Currently WIP -- the generic transform exists and is used, but this
currently misses some animation and glue cases.

This change is

highfive · 2017-10-04T22:59:07Z

Heads up! This PR modifies the following files:

@bholley: ports/geckolib/glue.rs, components/style/values/specified/transform.rs, components/style/properties/gecko.mako.rs, components/style/values/generics/transform.rs, components/style/gecko_bindings/sugar/ns_css_value.rs and 4 more
@canaltinova: components/style/values/specified/transform.rs, components/style/properties/gecko.mako.rs, components/style/values/generics/transform.rs, components/style/gecko_bindings/sugar/ns_css_value.rs, components/style/properties/helpers/animated_properties.mako.rs and 3 more
@emilio: components/layout/fragment.rs, ports/geckolib/glue.rs, components/style/values/specified/transform.rs, components/style/properties/gecko.mako.rs, components/style/values/generics/transform.rs and 6 more

highfive · 2017-10-04T22:59:08Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify style and layout code, but no tests are modified. Please consider adding a test!

bors-servo · 2017-10-10T19:14:19Z

☔ The latest upstream changes (presumably #18808) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo · 2017-10-27T22:16:42Z

☔ The latest upstream changes (presumably #19042) made this pull request unmergeable. Please resolve the merge conflicts.

Manishearth · 2017-10-31T01:03:53Z

r? @upsuper @BorisChiou @emilio

still have to test this, but the patches should be done

upsuper · 2017-10-31T01:04:53Z

I guess you can start a try run first?

Manishearth · 2017-10-31T01:23:46Z

I did.

Manishearth · 2017-10-31T01:24:12Z

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f52109811da74b04f4a0bfa6fc2ff3158f466b2e

jdm · 2017-10-31T03:10:33Z

There's a bunch of unit test build errors.

Manishearth · 2017-10-31T05:39:06Z

I'm aware, I've pushed up new tries


        Add support for transform functions with an optional final argument i…

…n gecko glue


        Add more operations to animation


        Handle animating 2D matrices


        Allow cross interpolation between differing translate/scale functions

See ToPrimitive() in StyleAnimationValue.cpp


        Handle case of empty transform lists


        Handle distance calculation of new variants


        Fix unit tests


        Rustfmt the new files


        Update test expectations


        Comments and minor fixes

Manishearth · 2017-11-02T21:38:20Z

@bors-servo r=emilio,xidorn

bors-servo · 2017-11-02T21:38:21Z

📌 Commit cb9645c has been approved by emilio,xidorn

bors-servo · 2017-11-02T22:02:09Z

⌛ Testing commit cb9645c with merge c494d25...


        Auto merge of #18750 - Manishearth:transform-generic, r=emilio,xidorn

Make transforms generic This makes the specified and computed value of transform share a generic backing enum. This will eventually be a complete fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1391145 , and also incidentally fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1405881 Currently WIP -- the generic transform exists and is used, but this currently misses some animation and glue cases.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18750)

bors-servo · 2017-11-02T22:43:58Z

💔 Test failed - linux-rel-css

Manishearth · 2017-11-02T22:45:13Z

@bors-servo retry

bors-servo · 2017-11-02T22:45:16Z

⚡ Previous build results for android, arm32, linux-dev, linux-rel-wpt, mac-rel-wpt3 are reusable. Rebuilding only arm64, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4, windows-msvc-dev...

bors-servo · 2017-11-02T23:24:17Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio,xidorn
Pushing c494d25 to master...

hiikezoe · 2017-11-02T23:34:44Z

Awesome! Thank you Manish!

emilio · 2017-11-02T23:37:46Z

You didn't squash it though... :(

Oh well, thanks for landing this!

highfive assigned mbrubeck Oct 4, 2017

highfive added the S-awaiting-review label Oct 4, 2017

Manishearth force-pushed the Manishearth:transform-generic branch from d7505bf to ac2d4f0 Oct 4, 2017

highfive added the S-needs-rebase label Oct 10, 2017

Manishearth force-pushed the Manishearth:transform-generic branch 2 times, most recently from 12a0c5c to e2d7cf6 Oct 23, 2017

highfive added the S-needs-rebase label Oct 27, 2017

Manishearth force-pushed the Manishearth:transform-generic branch 2 times, most recently from de3d9c6 to d9d3a64 Oct 30, 2017

Manishearth changed the title ~~[WIP] Make transforms generic~~ Make transforms generic Oct 31, 2017

highfive assigned upsuper and unassigned mbrubeck Oct 31, 2017

Manishearth force-pushed the Manishearth:transform-generic branch 4 times, most recently from eba9a1b to cf1581d Oct 31, 2017

jdm added S-needs-code-changes and removed S-needs-rebase labels Oct 31, 2017

Manishearth force-pushed the Manishearth:transform-generic branch from cf1581d to c579433 Oct 31, 2017

highfive removed the S-needs-code-changes label Oct 31, 2017

Manishearth added 10 commits Oct 30, 2017

Add support for transform functions with an optional final argument i…

Verified

This commit was signed with a verified signature.

Manishearth Manish Goregaokar

GPG key ID: 3BBF4D3E2EF79F98 Learn about signing commits

e156952

…n gecko glue

Add more operations to animation

Verified

This commit was signed with a verified signature.

Manishearth Manish Goregaokar

GPG key ID: 3BBF4D3E2EF79F98 Learn about signing commits

aba00be

Handle animating 2D matrices

Verified

This commit was signed with a verified signature.

Manishearth Manish Goregaokar

GPG key ID: 3BBF4D3E2EF79F98 Learn about signing commits

f699b8c

Allow cross interpolation between differing translate/scale functions

Verified

This commit was signed with a verified signature.

Manishearth Manish Goregaokar

GPG key ID: 3BBF4D3E2EF79F98 Learn about signing commits

9c9a181

See ToPrimitive() in StyleAnimationValue.cpp

Handle case of empty transform lists

Verified

This commit was signed with a verified signature.

Manishearth Manish Goregaokar

GPG key ID: 3BBF4D3E2EF79F98 Learn about signing commits

ca02785

Handle distance calculation of new variants

Verified

This commit was signed with a verified signature.

Manishearth Manish Goregaokar

GPG key ID: 3BBF4D3E2EF79F98 Learn about signing commits

5098948

Fix unit tests

Verified

This commit was signed with a verified signature.

Manishearth Manish Goregaokar

GPG key ID: 3BBF4D3E2EF79F98 Learn about signing commits

6415294

Rustfmt the new files

Verified

This commit was signed with a verified signature.

Manishearth Manish Goregaokar

GPG key ID: 3BBF4D3E2EF79F98 Learn about signing commits

1c12e0e

Update test expectations

Verified

This commit was signed with a verified signature.

Manishearth Manish Goregaokar

GPG key ID: 3BBF4D3E2EF79F98 Learn about signing commits

123bc1d

Comments and minor fixes

Verified

This commit was signed with a verified signature.

Manishearth Manish Goregaokar

GPG key ID: 3BBF4D3E2EF79F98 Learn about signing commits

Loading status checks…

cb9645c

Manishearth force-pushed the Manishearth:transform-generic branch from 2b3b3be to cb9645c Nov 2, 2017

highfive assigned emilio and unassigned upsuper Nov 2, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 2, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 2, 2017

bors-servo merged commit cb9645c into servo:master Nov 2, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

Manishearth deleted the Manishearth:transform-generic branch Nov 2, 2017

Manishearth mentioned this pull request Nov 2, 2017

Intermittent timeout on _mozilla/mozilla/referrer-policy/origin-when-cross-origin/meta-csp/cross-origin/http-https/iframe-tag/cross-origin.no-redirect.http.html #19102

Closed

servo / servo

Make transforms generic #18750

Make transforms generic #18750

Manishearth commented Oct 4, 2017 •

edited by SimonSapin

highfive commented Oct 4, 2017

highfive commented Oct 4, 2017

bors-servo commented Oct 10, 2017

bors-servo commented Oct 27, 2017

Manishearth commented Oct 31, 2017

upsuper commented Oct 31, 2017

Manishearth commented Oct 31, 2017

Manishearth commented Oct 31, 2017

jdm commented Oct 31, 2017 •

edited

Manishearth commented Oct 31, 2017

Manishearth commented Nov 2, 2017

bors-servo commented Nov 2, 2017

bors-servo commented Nov 2, 2017

bors-servo commented Nov 2, 2017

Manishearth commented Nov 2, 2017

bors-servo commented Nov 2, 2017

bors-servo commented Nov 2, 2017

hiikezoe commented Nov 2, 2017

emilio commented Nov 2, 2017

servo / servo

Join GitHub today

Make transforms generic #18750

Make transforms generic #18750

Conversation

Manishearth commented Oct 4, 2017 • edited by SimonSapin

highfive commented Oct 4, 2017

highfive commented Oct 4, 2017

bors-servo commented Oct 10, 2017

bors-servo commented Oct 27, 2017

Manishearth commented Oct 31, 2017

upsuper commented Oct 31, 2017

Manishearth commented Oct 31, 2017

Manishearth commented Oct 31, 2017

jdm commented Oct 31, 2017 • edited

Manishearth commented Oct 31, 2017

Manishearth commented Nov 2, 2017

bors-servo commented Nov 2, 2017

bors-servo commented Nov 2, 2017

bors-servo commented Nov 2, 2017

Manishearth commented Nov 2, 2017

bors-servo commented Nov 2, 2017

bors-servo commented Nov 2, 2017

hiikezoe commented Nov 2, 2017

emilio commented Nov 2, 2017

Manishearth commented Oct 4, 2017 •

edited by SimonSapin

jdm commented Oct 31, 2017 •

edited