New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make transforms generic #18750
Merged
+1,578
−1,345
Merged
Make transforms generic #18750
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
337d48a
Add generic struct for transform
Manishearth dcefcc3
Add ToComputedValue and ToCss impls
Manishearth d6525e0
Add specified and computed variants of Transform/TransformOperation
Manishearth 5449898
Add parsing support for transform
Manishearth 5031d14
Use a generic Matrix3D type
Manishearth 2de3464
Add ToAnimatedZero implementation
Manishearth 5ce2966
Add utilities for converting Transform to euclid types
Manishearth 6631594
Replace old transform code with new generic code
Manishearth 079b25d
Share transform function lists between set_transform and clone_transform
Manishearth fc29de8
Add support for more functions in Gecko glue
Manishearth e20c508
Add support for 2D matrices in Gecko glue
Manishearth e156952
Add support for transform functions with an optional final argument i…
Manishearth aba00be
Add more operations to animation
Manishearth f699b8c
Handle animating 2D matrices
Manishearth 9c9a181
Allow cross interpolation between differing translate/scale functions
Manishearth ca02785
Handle case of empty transform lists
Manishearth 5098948
Handle distance calculation of new variants
Manishearth 6415294
Fix unit tests
Manishearth 1c12e0e
Rustfmt the new files
Manishearth 123bc1d
Update test expectations
Manishearth cb9645c
Comments and minor fixes
Manishearth File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Allow cross interpolation between differing translate/scale functions
See ToPrimitive() in StyleAnimationValue.cpp
- Loading branch information
Manishearth
committed
Nov 2, 2017
Manishearth
Manish Goregaokar
commit 9c9a181f35280dabb5e089d9ae5df3fab1f6df1f
Verified
This commit was signed with a verified signature.
GPG key ID: 3BBF4D3E2EF79F98
Learn about signing commits
| @@ -706,6 +706,11 @@ impl CSSPixelLength { | ||
| pub fn abs(self) -> Self { | ||
| CSSPixelLength::new(self.0.abs()) | ||
| } | ||
|
|
||
| /// Zero value | ||
| pub fn zero() -> Self { | ||
emilio
Member
|
||
| CSSPixelLength::new(0.) | ||
| } | ||
| } | ||
|
|
||
| impl ToCss for CSSPixelLength { | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Also needs comments, and ideally link to spec.