Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web-platform-tests #18756

Merged
merged 9 commits into from Oct 5, 2017

Avoid endless testrunner restart loops.

If the first test selected by a testrunner thread had a CRASH expectation,
the testrunner believed that it needed to restart and would never actually
get around to running the test.
  • Loading branch information
jdm authored and Ms2ger committed Oct 4, 2017
commit da8677221e261730dd61405860eebe56cf2b1d07
@@ -154,6 +154,7 @@ def __init__(self, logger, browser, command_queue, no_timeout=False):
self.browser = browser
self.no_timeout = no_timeout
self.browser_settings = None
self.last_test = None

self.started = False

@@ -163,8 +164,9 @@ def update_settings(self, test):
browser_settings = self.browser.settings(test)
restart_required = ((self.browser_settings is not None and
self.browser_settings != browser_settings) or
test.expected() == "CRASH")
(self.last_test != test and test.expected() == "CRASH"))
self.browser_settings = browser_settings
self.last_test = test
return restart_required

def init(self):
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.