Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume that inputs to compute_style_with_inputs have any rules. #18767

Merged
merged 1 commit into from Oct 6, 2017

Conversation

@bzbarsky
Copy link
Contributor

commented Oct 6, 2017

It could be a text style, which never has any rules attached to it.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1406222


  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

Don't assume that inputs to compute_style_with_inputs have any rules.
It could be a text style, which never has any rules attached to it.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1406222
@highfive

This comment has been minimized.

Copy link

commented Oct 6, 2017

Heads up! This PR modifies the following files:

@highfive

This comment has been minimized.

Copy link

commented Oct 6, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@bzbarsky

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2017

@bors-servo r=heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2017

📌 Commit b488b32 has been approved by heycam

@bzbarsky

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2017

⌛️ Testing commit b488b32 with merge eb264b2...

bors-servo added a commit that referenced this pull request Oct 6, 2017
Auto merge of #18767 - bzbarsky:fix-inputs-no-rules, r=heycam
Don't assume that inputs to compute_style_with_inputs have any rules.

It could be a text style, which never has any rules attached to it.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1406222

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1406222

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18767)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2017

💔 Test failed - mac-rel-wpt1

@bzbarsky

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2017

⌛️ Testing commit b488b32 with merge 117dbfa...

bors-servo added a commit that referenced this pull request Oct 6, 2017
Auto merge of #18767 - bzbarsky:fix-inputs-no-rules, r=heycam
Don't assume that inputs to compute_style_with_inputs have any rules.

It could be a text style, which never has any rules attached to it.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1406222

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1406222

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18767)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2017

@bors-servo bors-servo merged commit b488b32 into servo:master Oct 6, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.