Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (fontconfig options, improved border AA). #18787

Closed
wants to merge 1 commit into from
Closed

Update WR (fontconfig options, improved border AA). #18787

wants to merge 1 commit into from

Conversation

@glennw
Copy link
Member

glennw commented Oct 8, 2017 •
edited by SimonSapin

Note that Servo doesn't actually read fontconfig information
yet, so we just pass through the default values to WR.

This change is Reviewable
@glennw
Copy link
Member Author

glennw commented Oct 8, 2017

r? anyone
@jdm
Copy link
Member

jdm commented Oct 8, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2017

📌 Commit 800f50d has been approved by jdm
@highfive highfive assigned jdm and unassigned wafflespeanut Oct 8, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2017

⌛ Testing commit 800f50d with merge 75272fd9ff310a60f5dbebe888e95d0570e98484...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2017

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Oct 9, 2017 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/css-transforms-3d-on-anonymous-block-001.htm
  └   → /css-transforms-1_dev/html/css-transforms-3d-on-anonymous-block-001.htm b1802cb5f030ef04d700f0443201136088368e14
/css-transforms-1_dev/html/reference/css-transforms-3d-anonymous-block-ref.htm 1ae3604ad8be9cb12795712bc8903240811d8ffa
Testing b1802cb5f030ef04d700f0443201136088368e14 == 1ae3604ad8be9cb12795712bc8903240811d8ffa
@glennw
Copy link
Member Author

glennw commented Oct 9, 2017

Unable to reproduce this locally, so far.
@gw3583
Update WR (fontconfig options, improved border AA).
Loading status checks…
97d7465 
Note that Servo doesn't actually *read* fontconfig information
yet, so we just pass through the default values to WR.
@glennw glennw force-pushed the glennw:update-wr-font-options branch from 800f50d to 97d7465 Oct 9, 2017
@glennw
Copy link
Member Author

glennw commented Oct 9, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2017

⌛ Trying commit 97d7465 with merge c065448...
bors-servo added a commit that referenced this pull request Oct 9, 2017
@bors-servo
Auto merge of #18787 - glennw:update-wr-font-options, r=<try>
Loading status checks…
c065448 
Update WR (fontconfig options, improved border AA).

Note that Servo doesn't actually *read* fontconfig information
yet, so we just pass through the default values to WR.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18787)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2017

💔 Test failed - android
@glennw
Copy link
Member Author

glennw commented Oct 9, 2017

@bors-servo retry

  • android oom?
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2017

⌛ Trying commit 97d7465 with merge 402e364...
bors-servo added a commit that referenced this pull request Oct 9, 2017
@bors-servo
Auto merge of #18787 - glennw:update-wr-font-options, r=<try>
Loading status checks…
402e364 
Update WR (fontconfig options, improved border AA).

Note that Servo doesn't actually *read* fontconfig information
yet, so we just pass through the default values to WR.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18787)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2017

💔 Test failed - linux-rel-css
@glennw
Copy link
Member Author

glennw commented Oct 11, 2017

Closing in favor of #18840.
@glennw glennw closed this Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-review S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@glennw @jdm @bors-servo @highfive @wafflespeanut @gw3583
You can’t perform that action at this time.