Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fix ex computation with more than one operand. #18807

Merged
merged 1 commit into from Oct 10, 2017
Merged

style: Fix ex computation with more than one operand. #18807

merged 1 commit into from Oct 10, 2017

Conversation

@emilio
Copy link
Member

emilio commented Oct 10, 2017 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Oct 10, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/specified/calc.rs
  • @canaltinova: components/style/values/specified/calc.rs
@highfive
Copy link

highfive commented Oct 10, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Oct 10, 2017

r? @jdm
@highfive highfive assigned jdm and unassigned nox Oct 10, 2017
@jdm
jdm approved these changes Oct 10, 2017
View changes
@jdm jdm added S-needs-tests and removed S-awaiting-review labels Oct 10, 2017
@emilio
style: Fix ex computation with more than one operand.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
90ee40f
@emilio emilio force-pushed the emilio:ex-calc branch from f8cbeab to 90ee40f Oct 10, 2017
@emilio
Copy link
Member Author

emilio commented Oct 10, 2017

Test added.

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2017

📌 Commit 90ee40f has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2017

⌛ Testing commit 90ee40f with merge ded289a...
bors-servo added a commit that referenced this pull request Oct 10, 2017
@bors-servo
Auto merge of #18807 - emilio:ex-calc, r=jdm
Loading status checks…
ded289a 
style: Fix ex computation with more than one operand.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18807)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2017

💔 Test failed - android
@jdm
Copy link
Member

jdm commented Oct 10, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2017

⌛ Testing commit 90ee40f with merge b1926b4...
bors-servo added a commit that referenced this pull request Oct 10, 2017
@bors-servo
Auto merge of #18807 - emilio:ex-calc, r=jdm
Loading status checks…
b1926b4 
style: Fix ex computation with more than one operand.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18807)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing b1926b4 to master...
@bors-servo bors-servo merged commit 90ee40f into servo:master Oct 10, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the emilio:ex-calc branch Oct 11, 2017
jdm added a commit to web-platform-tests/wpt that referenced this pull request Oct 12, 2017
@emilio @jdm
style: Fix ex computation with more than one operand.
ecf0f62 
Upstreamed from servo/servo#18807 [ci skip]
@servo-wpt-sync servo-wpt-sync mentioned this pull request Oct 12, 2017
Merged
jakearchibald added a commit to jakearchibald/web-platform-tests that referenced this pull request Nov 16, 2017
@emilio @jakearchibald
style: Fix ex computation with more than one operand.
2c3f546 
Upstreamed from servo/servo#18807 [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
S-needs-tests
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @bors-servo @jdm @nox
You can’t perform that action at this time.