Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadeps to remove duplicate error-chain crate #18821

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
6 participants
@SimonSapin
Copy link
Member

commented Oct 10, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Oct 10, 2017

Heads up! This PR modifies the following files:

@jdm

This comment has been minimized.

Copy link
Member

commented Oct 10, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2017

📌 Commit c2f0ef2 has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2017

⌛️ Testing commit c2f0ef2 with merge c85130dedd0cf920486b70ce6865d4700c782c65...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2017

💔 Test failed - arm32

@SimonSapin

This comment has been minimized.

Copy link
Member Author

commented Oct 11, 2017

configure: error: in `/home/servo/buildbot/slave/arm32/build/target/release/build/backtrace-sys-ef6211128d6f7e04/out':
configure: error: C compiler cannot create executables
See `config.log' for more details.
thread 'main' panicked at 'failed with: exit code: 77', /home/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-sys-0.1.11/build.rs:136:8

Looks unrelated.

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2017

⌛️ Testing commit c2f0ef2 with merge 68b2da1...

bors-servo added a commit that referenced this pull request Oct 11, 2017

Auto merge of #18821 - servo:dupdep, r=jdm
Update metadeps to remove duplicate error-chain crate

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18821)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2017

💔 Test failed - arm64

@SimonSapin

This comment has been minimized.

Copy link
Member Author

commented Oct 11, 2017

Same error message again, on the same machine.

@jdm

This comment has been minimized.

Copy link
Member

commented Oct 11, 2017

Investigating in servo/saltfs#683.

@jdm

This comment has been minimized.

Copy link
Member

commented Oct 11, 2017

@bors-servo: retry

  • going to try to debug on the build machines
@jdm

This comment has been minimized.

Copy link
Member

commented Oct 11, 2017

@bors-servo: r- try

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2017

⌛️ Trying commit c2f0ef2 with merge f21e08e...

bors-servo added a commit that referenced this pull request Oct 11, 2017

Auto merge of #18821 - servo:dupdep, r=<try>
Update metadeps to remove duplicate error-chain crate

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18821)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2017

💔 Test failed - arm64

@jdm

This comment has been minimized.

Copy link
Member

commented Oct 11, 2017

We need servo/saltfs#732 to be deployed before this can merge.

@jdm

This comment has been minimized.

Copy link
Member

commented Oct 13, 2017

@bors-servo: retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 13, 2017

⌛️ Trying commit c2f0ef2 with merge 63bf339...

bors-servo added a commit that referenced this pull request Oct 13, 2017

Auto merge of #18821 - servo:dupdep, r=<try>
Update metadeps to remove duplicate error-chain crate

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18821)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 13, 2017

💔 Test failed - arm32

@SimonSapin

This comment has been minimized.

Copy link
Member Author

commented Oct 13, 2017

Same error again.

@jdm

This comment has been minimized.

Copy link
Member

commented Oct 14, 2017

Yeah, the deploy did not successfully occur, hence servo/saltfs#734.

@jdm

This comment has been minimized.

Copy link
Member

commented Nov 6, 2017

@bors-servo: retry

@edunham

This comment has been minimized.

Copy link
Member

commented Nov 9, 2017

@bors-servo retry

@jdm

This comment has been minimized.

Copy link
Member

commented Nov 9, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2017

📌 Commit c2f0ef2 has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2017

⌛️ Testing commit c2f0ef2 with merge ff1b583...

bors-servo added a commit that referenced this pull request Nov 9, 2017

Auto merge of #18821 - servo:dupdep, r=jdm
Update metadeps to remove duplicate error-chain crate

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18821)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2017

@bors-servo bors-servo merged commit c2f0ef2 into master Nov 9, 2017

3 of 4 checks passed

dependency-ci Checking Dependencies
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@SimonSapin SimonSapin deleted the dupdep branch Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.