Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove some usage of unstable features #18839
Merged
+224
−217
Conversation
highfive
commented
Oct 11, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Oct 11, 2017
|
|
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Oct 12, 2017
Remove some usage of unstable features `Box::new(x)` seems to compile to exactly the same assembly as `box x` in release mode: https://play.rust-lang.org/?gist=55ec5dd02c22fa799375d6e2e1a6e970&version=nightly <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18839) <!-- Reviewable:end -->
|
|
|
IIRC removing |
|
3 remarks, but r=me if you don't want to make the suggested changes. |
| @@ -109,7 +109,8 @@ fn is_image_opaque(format: webrender_api::ImageFormat, bytes: &[u8]) -> bool { | |||
| fn premultiply(data: &mut [u8]) { | |||
| let length = data.len(); | |||
|
|
|||
| for i in Iterator::step_by(0..length, 4) { | |||
| let mut i = 0; | |||
| while i < length { | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SimonSapin
Oct 12, 2017
Author
Member
The last item of chunks can be a smaller slice, whereas this loop will stop before.
| @@ -50,14 +50,17 @@ pub struct ImageMetadata { | |||
| fn byte_swap_and_premultiply(data: &mut [u8]) { | |||
| let length = data.len(); | |||
|
|
|||
| for i in Iterator::step_by(0..length, 4) { | |||
| let mut i = 0; | |||
| while i < length { | |||
This comment has been minimized.
This comment has been minimized.
components/script/dom/element.rs
Outdated
|
|
||
| fn try_from(position: &'a str) -> Result<AdjacentPosition, Self::Error> { | ||
| impl AdjacentPosition { | ||
| fn try_from(position: &str) -> Result<AdjacentPosition, Error> { |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=nox |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 12, 2017
Remove some usage of unstable features `Box::new(x)` seems to compile to exactly the same assembly as `box x` in release mode: https://play.rust-lang.org/?gist=55ec5dd02c22fa799375d6e2e1a6e970&version=nightly <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18839) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedOct 11, 2017
•
edited
Box::new(x)seems to compile to exactly the same assembly asbox xin release mode:https://play.rust-lang.org/?gist=55ec5dd02c22fa799375d6e2e1a6e970&version=nightly
This change is