Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLimit visited cascade for reparenting #18844
Merged
Conversation
The specialized cascade flow in `stylist::compute_style_with_inputs` (used with reparenting) currently computes all properties for visited styles, but we only need visited-dependent properties. This adds the cascade flag to reduce the work to visited-dependent properties only, like we do for the regular cascade flow. MozReview-Commit-ID: FGCj6GPnQOB
highfive
commented
Oct 12, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Oct 12, 2017
|
|
|
@bors-servo r=emilio |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 12, 2017
Limit visited cascade for reparenting The specialized cascade flow in `stylist::compute_style_with_inputs` (used with reparenting) currently computes all properties for visited styles, but we only need visited-dependent properties. This adds the cascade flag to reduce the work to visited-dependent properties only, like we do for the regular cascade flow. https://bugzilla.mozilla.org/show_bug.cgi?id=1407813 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18844) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jryans commentedOct 12, 2017
•
edited by SimonSapin
The specialized cascade flow in
stylist::compute_style_with_inputs(used withreparenting) currently computes all properties for visited styles, but we only
need visited-dependent properties.
This adds the cascade flag to reduce the work to visited-dependent properties
only, like we do for the regular cascade flow.
https://bugzilla.mozilla.org/show_bug.cgi?id=1407813
This change is