Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDolt #18846
Dolt #18846
Conversation
highfive
commented
Oct 12, 2017
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. |
highfive
commented
Oct 12, 2017
|
Heads up! This PR modifies the following files:
|
|
You will want to rebase only the final commit on a recent upstream commit. Also, a more informative PR title would help ;) |
|
What's the status of this? |
|
Closing due to inactivity. Feel free to ping us if you're planning to work on something again. :) |
|
I apologize for not updating the status. If anyone is not working on |
|
No worries! Apparently #11416 never got unassigned, and I don't think anyone's working on it. So, please go ahead! |
Rakhisharma commentedOct 12, 2017
•
edited by SimonSapin
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is