Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dolt #18846

Closed
wants to merge 6 commits into from
Closed

Dolt #18846

wants to merge 6 commits into from

Conversation

@Rakhisharma
Copy link
Contributor

Rakhisharma commented Oct 12, 2017


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #11416 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

Rakhisharma added 6 commits Sep 21, 2017
@highfive
Copy link

highfive commented Oct 12, 2017

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

@highfive
Copy link

highfive commented Oct 12, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/servo/media_queries.rs
  • @canaltinova: components/style/servo/media_queries.rs
  • @KiChjang: components/script/test.rs, components/script/dom/webidls/HTMLPictureElement.webidl, components/script/dom/webidls/HTMLImageElement.webidl, components/script/dom/htmlimageelement.rs, components/script/dom/htmlpictureelement.rs
  • @fitzgen: components/script/test.rs, components/script/dom/webidls/HTMLPictureElement.webidl, components/script/dom/webidls/HTMLImageElement.webidl, components/script/dom/htmlimageelement.rs, components/script/dom/htmlpictureelement.rs
  • @emilio: components/style/servo/media_queries.rs
@jdm
Copy link
Member

jdm commented Oct 12, 2017

You will want to rebase only the final commit on a recent upstream commit. Also, a more informative PR title would help ;)

@wafflespeanut
Copy link
Member

wafflespeanut commented Nov 8, 2017

What's the status of this?

@wafflespeanut
Copy link
Member

wafflespeanut commented Nov 10, 2017

Closing due to inactivity. Feel free to ping us if you're planning to work on something again. :)

@Rakhisharma
Copy link
Contributor Author

Rakhisharma commented Nov 23, 2017

I apologize for not updating the status. If anyone is not working on Picture element part I would like to pick it up again. Thanks.

@wafflespeanut
Copy link
Member

wafflespeanut commented Nov 23, 2017

No worries! Apparently #11416 never got unassigned, and I don't think anyone's working on it. So, please go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.