Make optional the usage of some unstable features #18854

SimonSapin · 2017-10-12T17:21:25Z

With --no-default-features --features default-except-unstable, more crates can now be compiled on stable Rust. This will help integrate them in rustc’s regression testing and compiler performance benchmarking.

This change is


        Rename the 'unstable' feature of the selectors crate to 'bench'


        Add an 'unstable' top-level cargo feature to control optional unstabl…

…e stuff.


        Remove default features in components/servo

They are covered by ports/servo’s defaults.

nox

I have some concerns about building individual crates with ./mach build, and at least one feature in this isn't additive.

nox · 2017-10-13T08:49:05Z

components/selectors/Cargo.toml

@@ -20,7 +20,7 @@ doctest = false

 [features]
 gecko_like_types = []
-unstable = []
+bench = []


Breaking change, right?

Yeah, but not the first since we moved this crate in this repo and stopped caring about the version number.

nox · 2017-10-13T08:49:05Z

components/layout_thread/Cargo.toml

@@ -9,6 +9,9 @@ publish = false
 name = "layout_thread"
 path = "lib.rs"

+[features]
+unstable = ["parking_lot/nightly"]


With this, what gets built if I run ./mach build -p layout_thread?

nox · 2017-10-13T08:49:05Z

components/nonzero/lib.rs

+    extern crate core;
+    use self::core::nonzero::NonZero;
+
+    pub type NonZeroU32 = NonZero<u32>;


Make a wrapper even in this branch.

nox · 2017-10-13T08:49:05Z

components/compositing/Cargo.toml

@@ -9,6 +9,9 @@ publish = false
 name = "compositing"
 path = "lib.rs"

+[features]
+unstable = ["nonzero/unstable"]


What gets built if I run ./mach build -p compositing?

nox · 2017-10-13T08:49:05Z

components/nonzero/lib.rs

@@ -19,10 +19,14 @@ mod imp {
    use self::core::nonzero::NonZero;

    pub type NonZeroU32 = NonZero<u32>;
+    pub type NonZeroUsize = NonZero<usize>;


No, make a wrapper.

Yes, I did that in a later commit.

nox · 2017-10-13T08:49:05Z

components/gfx/Cargo.toml

@@ -10,6 +10,9 @@ publish = false
 name = "gfx"
 path = "lib.rs"

+[features]
+unstable = ["simd"]


What gets built if I run ./mach build -p gfx?

nox · 2017-10-13T08:49:05Z

components/profile/Cargo.toml

@@ -9,6 +9,9 @@ publish = false
 name = "profile"
 path = "lib.rs"

+[features]
+unstable = []


What gets built if I run ./mach build -p profile?

nox · 2017-10-13T08:49:05Z

components/constellation/constellation.rs

+    #[cfg(not(feature = "unstable"))]
+    /// The joint session future is the merge of the session future of every
+    /// browsing_context, sorted chronologically.
+    fn joint_session_future<'a>(&'a self, top_level_browsing_context_id: TopLevelBrowsingContextId)


This is incorrect, features are supposed to be additive and this is not.

Features being additive is important when one library might be used in the same projects by multiple crate maintained by different people. But the constellation crate is not intended to be used outside of this repository. We’ve never worried about backward compat within components/*.

nox · 2017-10-13T08:49:05Z

components/canvas_traits/webgl.rs

 use euclid::Size2D;
+use nonzero::NonZeroU32;


Please squash this commit ("Make tidy happy") with the rest of the changes.

SimonSapin · 2017-10-13T08:59:28Z

Regarding ./mach build -p gfx etc, there’s a bug in Cargo: rust-lang/cargo#4463

nox · 2017-10-13T09:03:58Z

I'm not sure how that Cargo bug relates, given its spurious rebuilds occur even with the same features selected. My issue is that ./mach build will build Servo with unstable features because the top-level crate uses them, whereas ./mach build -p gfx without explicitly passing a --features argument will select a different set of features.


        Add a nonzero crate


        Use the new nonzero crate in the msg crate


        Add NonZeroUsize


        Use NonZeroUsize in remutex


        Use NonZeroU32 in canvas_traits


        Make usage of simd in gfx optional


        Make use of unstable alloc_jemalloc crate optional


        Abuse Vec as an allocator in gfx


        Use NonZeroUsize in script_layout_interface


        Make use of `impl trait` in constellation optional


        Use wrappers in the nonzero crate so users don’t need unstable features


        Add a default-except-unstable feature


        Remove usage of unstable feature conservative_impl_trait in layout


        Remove usage of unstable feature "raw"


        Remove usage of unstable feature box_patterns

SimonSapin · 2017-10-13T09:13:59Z

My issue is that ./mach build will build Servo with unstable features because the top-level crate uses them, whereas ./mach build -p gfx without explicitly passing a --features argument will select a different set of features.

Yes, because of that bug. And fixing that bug in Cargo will fix that problem. In the meantime I don’t know what to do about it. Adding default = […] and default-features = false everywhere doesn’t seem great.

nox · 2017-10-13T09:15:10Z

Yes, because of that bug. And fixing that bug in Cargo will fix that problem.

I don't understand how this is considered a bug. Why should the workspace itself decide which features get used? That wouldn't even work for Servo, where Servo and geckolib don't use the same variants for all the crates.

SimonSapin · 2017-10-13T09:20:55Z

If I understand correctly, feature selection would be based on which top-level crate is being compiled, which itself is based on --manifest-path or the current directory. ./mach build changes into ports/servo before running Cargo.

nox · 2017-10-13T09:22:47Z

So there would still be an issue, where building gfx directly wouldn't build the same gfx as the one that is built when running ./mach build. The Cargo issue seems to be about entirely wrong compiles, my concern is about rebuilding gfx for no reason.

SimonSapin · 2017-10-13T09:24:11Z

With the bug fixed, cargo build --manifest-path ports/servo/Cargo.toml -p style would enable the style/servo feature and cargo build --manifest-path ports/geckolib/Cargo.toml -p style would enable the style/gecko feature.

SimonSapin · 2017-10-13T10:02:49Z

@bors-servo r=nox (per IRC)

bors-servo · 2017-10-13T10:02:50Z

📌 Commit 11bd81e has been approved by nox

bors-servo · 2017-10-13T10:02:54Z

⌛ Testing commit 11bd81e with merge ab761a3...


        Auto merge of #18854 - servo:servo-unstable-feature, r=nox

Make optional the usage of some unstable features With `--no-default-features --features default-except-unstable`, more crates can now be compiled on stable Rust. This will help integrate them in rustc’s regression testing and compiler performance benchmarking.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18854)

bors-servo · 2017-10-13T11:14:39Z

💔 Test failed - mac-rel-wpt4

jdm · 2017-10-13T13:39:33Z

@bors-servo: retry

#18866

bors-servo · 2017-10-13T14:41:58Z

⌛ Testing commit 11bd81e with merge 8b3d553...


        Auto merge of #18854 - servo:servo-unstable-feature, r=nox

Make optional the usage of some unstable features With `--no-default-features --features default-except-unstable`, more crates can now be compiled on stable Rust. This will help integrate them in rustc’s regression testing and compiler performance benchmarking.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18854)

bors-servo · 2017-10-13T15:48:55Z

💔 Test failed - linux-rel-css

SimonSapin · 2017-10-13T15:51:42Z

TIMEOUT [expected FAIL] /selectors-3_dev/xhtml1print/grid-first-letter-003.xht

  ▶ TIMEOUT [expected FAIL] /selectors-3_dev/xhtml1print/grid-first-letter-003.xht
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  │ 3.3 (Core Profile) Mesa 17.2.0-devel
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  │ 3.3 (Core Profile) Mesa 17.2.0-devel
  │ called `Result::unwrap()` on an `Err` value: Io(Error { repr: Os { code: 32, message: "Broken pipe" } }) (thread FontCacheThread, at /checkout/src/libcore/result.rs:906)
  │ stack backtrace:
  │    0:     0x7fb5c97b83dc - backtrace::backtrace::trace::hec7ae591db5c7608
  │    1:     0x7fb5c97b8412 - backtrace::capture::Backtrace::new::hb67fc1d62ccb892b
  │    2:     0x7fb5c74f5505 - servo::main::{{closure}}::had3fb0051711e302
  │    3:     0x7fb5c98163b6 - std::panicking::rust_panic_with_hook
  │                         at /checkout/src/libstd/panicking.rs:578
  │    4:     0x7fb5c98161d4 - std::panicking::begin_panic<alloc::string::String>
  │                         at /checkout/src/libstd/panicking.rs:538
  │    5:     0x7fb5c9816149 - std::panicking::begin_panic_fmt
  │                         at /checkout/src/libstd/panicking.rs:522
  │    6:     0x7fb5c98160da - std::panicking::rust_begin_panic
  │                         at /checkout/src/libstd/panicking.rs:498
  │    7:     0x7fb5c98502d0 - core::panicking::panic_fmt
  │                         at /checkout/src/libcore/panicking.rs:71
  │    8:     0x7fb5c94751d1 - core::result::unwrap_failed::hf4602dd5e22e9990
  │    9:     0x7fb5c9477d68 - webrender_api::api::RenderApi::update_resources::h189284108e52c764
  │   10:     0x7fb5c8ee861a - gfx::font_cache_thread::FontCache::run::h17098598ad9cc0da
  │   11:     0x7fb5c8ecb378 - std::sys_common::backtrace::__rust_begin_short_backtrace::h754c10d8ab0fc1f3
  │   12:     0x7fb5c8ecbba4 - std::panicking::try::do_call::hf2c4cb937ecc7ffc
  │   13:     0x7fb5c981d4fc - panic_unwind::__rust_maybe_catch_panic
  │                         at /checkout/src/libpanic_unwind/lib.rs:99
  │   14:     0x7fb5c8ed5f2d - <F as alloc::boxed::FnBox<A>>::call_box::hacfdd34c8d32b1ed
  │   15:     0x7fb5c98150cb - alloc::boxed::{{impl}}::call_once<(),()>
  │                         at /checkout/src/liballoc/boxed.rs:772
  │                          - std::sys_common::thread::start_thread
  │                         at /checkout/src/libstd/sys_common/thread.rs:24
  │                          - std::sys::imp::thread::{{impl}}::new::thread_start
  │                         at /checkout/src/libstd/sys/unix/thread.rs:90
  │   16:     0x7fb5c51ab183 - start_thread
  │   17:     0x7fb5c4cc1ffc - clone
  │   18:                0x0 - <unknown>
  │ ERROR:servo: called `Result::unwrap()` on an `Err` value: Io(Error { repr: Os { code: 32, message: "Broken pipe" } })
  │ failed to receive response to font request: Io(Error { repr: Os { code: 104, message: "Connection reset by peer" } }) (thread LayoutThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(NonZeroU32(NonZero(1))) }, at /checkout/src/libcore/result.rs:906)
  │ stack backtrace:
  │    0:     0x7fb5c97b83dc - backtrace::backtrace::trace::hec7ae591db5c7608
  │    1:     0x7fb5c97b8412 - backtrace::capture::Backtrace::new::hb67fc1d62ccb892b
  │    2:     0x7fb5c74f5505 - servo::main::{{closure}}::had3fb0051711e302
  │    3:     0x7fb5c98163b6 - std::panicking::rust_panic_with_hook
  │                         at /checkout/src/libstd/panicking.rs:578
  │    4:     0x7fb5c98161d4 - std::panicking::begin_panic<alloc::string::String>
  │                         at /checkout/src/libstd/panicking.rs:538
  │    5:     0x7fb5c9816149 - std::panicking::begin_panic_fmt
  │                         at /checkout/src/libstd/panicking.rs:522
  │    6:     0x7fb5c98160da - std::panicking::rust_begin_panic
  │                         at /checkout/src/libstd/panicking.rs:498
  │    7:     0x7fb5c98502d0 - core::panicking::panic_fmt
  │                         at /checkout/src/libcore/panicking.rs:71
  │    8:     0x7fb5c8ed5ba1 - core::result::unwrap_failed::he7b7c5c12b9b8432
  │    9:     0x7fb5c8ef27c4 - gfx::font_cache_thread::FontCacheThread::get_font_instance::h81efb3a1f9a2d72a
  │   10:     0x7fb5c8ef3127 - gfx::font_context::FontContext::create_layout_font::h7cafe11e319cc768
  │   11:     0x7fb5c8ef3dfc - gfx::font_context::FontContext::layout_font_group_for_style::hcfb66eb349aedc42
  │   12:     0x7fb5c780f741 - layout::text::TextRunScanner::scan_for_runs::h534e004494cb0df8
  │   13:     0x7fb5c7723612 - <layout::construct::FlowConstructor<'a, ConcreteThreadSafeLayoutNode>>::build_flow_for_block_starting_with_fragments::ha215179782ccf9e6
  │   14:     0x7fb5c77220f4 - <layout::construct::FlowConstructor<'a, ConcreteThreadSafeLayoutNode>>::build_flow_for_block_like::h1dc7baa0fa39d43a
  │   15:     0x7fb5c77216ed - <layout::construct::FlowConstructor<'a, ConcreteThreadSafeLayoutNode>>::build_flow_for_block::hcb366551687a0fd0
  │   16:     0x7fb5c7698af2 - <layout::construct::FlowConstructor<'a, ConcreteThreadSafeLayoutNode> as layout::traversal::PostorderNodeMutTraversal<ConcreteThreadSafeLayoutNode>>::process::he1ba8292623b5232
  │   17:     0x7fb5c76f5321 - style::traversal::DomTraversal::handle_postorder_traversal::h9a9f086d232794d8
  │   18:     0x7fb5c775e087 - layout_thread::LayoutThread::handle_reflow::h08e10bdb7bc88478
  │   19:     0x7fb5c774fa94 - layout_thread::LayoutThread::handle_request_helper::ha966420573ae5b4f
  │   20:     0x7fb5c774b390 - <layout_thread::LayoutThread as layout_traits::LayoutThreadFactory>::create::{{closure}}::h259474fca527c891
  │   21:     0x7fb5c76ae3b5 - std::sys_common::backtrace::__rust_begin_short_backtrace::h91d5b316355deb44
  │   22:     0x7fb5c76b1f35 - std::panicking::try::do_call::h7b171f4e959dd588
  │   23:     0x7fb5c981d4fc - panic_unwind::__rust_maybe_catch_panic
  │                         at /checkout/src/libpanic_unwind/lib.rs:99
  │   24:     0x7fb5c76e19d2 - <F as alloc::boxed::FnBox<A>>::call_box::hae49c8c84b363d3b
  │   25:     0x7fb5c98150cb - alloc::boxed::{{impl}}::call_once<(),()>
  │                         at /checkout/src/liballoc/boxed.rs:772
  │                          - std::sys_common::thread::start_thread
  │                         at /checkout/src/libstd/sys_common/thread.rs:24
  │                          - std::sys::imp::thread::{{impl}}::new::thread_start
  │                         at /checkout/src/libstd/sys/unix/thread.rs:90
  │   26:     0x7fb5c51ab183 - start_thread
  │   27:     0x7fb5c4cc1ffc - clone
  │   28:                0x0 - <unknown>
  │ ERROR:servo: failed to receive response to font request: Io(Error { repr: Os { code: 104, message: "Connection reset by peer" } })
  │ assertion failed: !self.Document().needs_reflow() ||
  │     (!for_display && self.Document().needs_paint()) ||
  │     self.window_size.get().is_none() || self.suppress_reflow.get() (thread ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(NonZeroU32(NonZero(1))) }, at /home/servo/buildbot/slave/linux-rel-css/build/components/script/dom/window.rs:1338)
  │ stack backtrace:
  │    0:     0x7fb5c97b83dc - backtrace::backtrace::trace::hec7ae591db5c7608
  │    1:     0x7fb5c97b8412 - backtrace::capture::Backtrace::new::hb67fc1d62ccb892b
  │    2:     0x7fb5c74f5505 - servo::main::{{closure}}::had3fb0051711e302
  │    3:     0x7fb5c98163b6 - std::panicking::rust_panic_with_hook
  │                         at /checkout/src/libstd/panicking.rs:578
  │    4:     0x7fb5c78a35ba - std::panicking::begin_panic::h39d93994ecc53727
  │    5:     0x7fb5c80294a7 - script::dom::window::Window::reflow::h7f6f2ec853c835b7
  │    6:     0x7fb5c7e45db7 - script::dom::document::Document::finish_load::h1be96fb44e771c54
  │    7:     0x7fb5c7f9a4a1 - script::dom::servoparser::ServoParser::do_parse_sync::h3e4c46deccfaa80c
  │    8:     0x7fb5c7f99c36 - script::dom::servoparser::ServoParser::parse_sync::hc140f2be00400af4
  │    9:     0x7fb5c7f9eb0b - <script::dom::servoparser::ParserContext as net_traits::FetchResponseListener>::process_response_eof::h72a45879ad646db9
  │   10:     0x7fb5c807ae58 - script::script_thread::ScriptThread::handle_msg_from_constellation::hbd0c6bb93f5c9ecc
  │   11:     0x7fb5c8074eaf - script::script_thread::ScriptThread::handle_msgs::{{closure}}::hf1ef8951038742c5
  │   12:     0x7fb5c8070c64 - script::script_thread::ScriptThread::handle_msgs::hc7dc8d41f6ae010d
  │   13:     0x7fb5c806c26b - script::script_thread::ScriptThread::start::h4462f3086dc3d480
  │   14:     0x7fb5c789ad22 - std::sys_common::backtrace::__rust_begin_short_backtrace::h827bbdc342243b9b
  │   15:     0x7fb5c7974495 - std::panicking::try::do_call::h614c0e1beac71ffd
  │   16:     0x7fb5c981d4fc - panic_unwind::__rust_maybe_catch_panic
  │                         at /checkout/src/libpanic_unwind/lib.rs:99
  │   17:     0x7fb5c7bf5742 - <F as alloc::boxed::FnBox<A>>::call_box::h61a9f1b3aae17011
  │   18:     0x7fb5c98150cb - alloc::boxed::{{impl}}::call_once<(),()>
  │                         at /checkout/src/liballoc/boxed.rs:772
  │                          - std::sys_common::thread::start_thread
  │                         at /checkout/src/libstd/sys_common/thread.rs:24
  │                          - std::sys::imp::thread::{{impl}}::new::thread_start
  │                         at /checkout/src/libstd/sys/unix/thread.rs:90
  │   19:     0x7fb5c51ab183 - start_thread
  │   20:     0x7fb5c4cc1ffc - clone
  │   21:                0x0 - <unknown>
  │ ERROR:servo: assertion failed: !self.Document().needs_reflow() ||
  │     (!for_display && self.Document().needs_paint()) ||
  └     self.window_size.get().is_none() || self.suppress_reflow.get()

SimonSapin · 2017-10-13T15:55:50Z

@bors-servo retry #13730

bors-servo · 2017-10-13T17:26:41Z

⌛ Testing commit 11bd81e with merge 78aaa85...


        Auto merge of #18854 - servo:servo-unstable-feature, r=nox

Make optional the usage of some unstable features With `--no-default-features --features default-except-unstable`, more crates can now be compiled on stable Rust. This will help integrate them in rustc’s regression testing and compiler performance benchmarking.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18854)

bors-servo · 2017-10-13T19:10:57Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 78aaa85 to master...

SimonSapin added 3 commits Oct 11, 2017

Rename the 'unstable' feature of the selectors crate to 'bench'

c496aa1

Add an 'unstable' top-level cargo feature to control optional unstabl…

132b540

…e stuff.

Remove default features in components/servo

faff780

They are covered by ports/servo’s defaults.

jdm added the S-awaiting-review label Oct 12, 2017

jdm assigned nox Oct 12, 2017

SimonSapin force-pushed the servo-unstable-feature branch from 8ca7c3e to 01e2f3d Oct 12, 2017

nox requested changes Oct 13, 2017

View changes

SimonSapin added 15 commits Oct 11, 2017

Add a nonzero crate

c4bf3ec

Use the new nonzero crate in the msg crate

57709dc

Add NonZeroUsize

8cdf2ad

Use NonZeroUsize in remutex

ecf3b05

Use NonZeroU32 in canvas_traits

5e72173

Make usage of simd in gfx optional

d9a3119

Make use of unstable alloc_jemalloc crate optional

d6d772e

Abuse Vec as an allocator in gfx

ff23a85

Use NonZeroUsize in script_layout_interface

7ebedd0

Make use of `impl trait` in constellation optional

45fd384

Use wrappers in the nonzero crate so users don’t need unstable features

4594b40

Add a default-except-unstable feature

c2d6600

Remove usage of unstable feature conservative_impl_trait in layout

4727b92

Remove usage of unstable feature "raw"

e13ae77

Remove usage of unstable feature box_patterns

Loading status checks…

11bd81e

SimonSapin force-pushed the servo-unstable-feature branch from 01e2f3d to 11bd81e Oct 13, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Oct 13, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Oct 13, 2017

highfive added S-awaiting-merge and removed S-tests-failed labels Oct 13, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Oct 13, 2017

highfive added S-awaiting-merge and removed S-tests-failed labels Oct 13, 2017

bors-servo mentioned this pull request Oct 13, 2017

Switch to using WebRender hit testing #18704

Merged

3 of 5 tasks complete

highfive removed the S-awaiting-merge label Oct 13, 2017

bors-servo mentioned this pull request Oct 13, 2017

[WIP] Ensure every inline flow starts and ends with a text fragment. #18780

Open

1 of 4 tasks complete

SimonSapin deleted the servo-unstable-feature branch Oct 13, 2017

SimonSapin mentioned this pull request Oct 13, 2017

Tracking: Unstable Rust feature gates used by Servo #5286

Closed

90 of 99 tasks complete

servo / servo

Make optional the usage of some unstable features #18854

Make optional the usage of some unstable features #18854

SimonSapin commented Oct 12, 2017 •

edited

nox left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SimonSapin commented Oct 13, 2017

nox commented Oct 13, 2017

SimonSapin commented Oct 13, 2017

nox commented Oct 13, 2017

SimonSapin commented Oct 13, 2017

nox commented Oct 13, 2017

SimonSapin commented Oct 13, 2017

SimonSapin commented Oct 13, 2017

bors-servo commented Oct 13, 2017

bors-servo commented Oct 13, 2017

bors-servo commented Oct 13, 2017

jdm commented Oct 13, 2017

bors-servo commented Oct 13, 2017

bors-servo commented Oct 13, 2017

SimonSapin commented Oct 13, 2017 •

edited

SimonSapin commented Oct 13, 2017

bors-servo commented Oct 13, 2017

bors-servo commented Oct 13, 2017

servo / servo

Join GitHub today

Make optional the usage of some unstable features #18854

Make optional the usage of some unstable features #18854

Conversation

SimonSapin commented Oct 12, 2017 • edited

nox left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SimonSapin commented Oct 13, 2017

nox commented Oct 13, 2017

SimonSapin commented Oct 13, 2017

nox commented Oct 13, 2017

SimonSapin commented Oct 13, 2017

nox commented Oct 13, 2017

SimonSapin commented Oct 13, 2017

SimonSapin commented Oct 13, 2017

bors-servo commented Oct 13, 2017

bors-servo commented Oct 13, 2017

bors-servo commented Oct 13, 2017

jdm commented Oct 13, 2017

bors-servo commented Oct 13, 2017

bors-servo commented Oct 13, 2017

SimonSapin commented Oct 13, 2017 • edited

SimonSapin commented Oct 13, 2017

bors-servo commented Oct 13, 2017

bors-servo commented Oct 13, 2017

SimonSapin commented Oct 12, 2017 •

edited

SimonSapin commented Oct 13, 2017 •

edited