Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle: Share code between Gecko and Servo for DOM APIs. #18863
Merged
+93
−60
Conversation
highfive
commented
Oct 13, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Oct 13, 2017
|
|
emilio
force-pushed the
emilio:dom-api-dont-repeat
branch
2 times, most recently
from
d5d7476
to
8444e5d
components/script/dom/element.rs
Outdated
| Ok(matches_selector_list(&selectors, &root, &mut ctx)) | ||
| } | ||
| } | ||
| use style::dom_apis; |
This comment has been minimized.
This comment has been minimized.
components/script/dom/element.rs
Outdated
| Ok(None) | ||
| } | ||
| } | ||
| use style::dom_apis; |
This comment has been minimized.
This comment has been minimized.
components/script/dom/element.rs
Outdated
| Ok(selectors) => selectors, | ||
| }; | ||
|
|
||
| let self_root = DomRoot::from_ref(self); |
This comment has been minimized.
This comment has been minimized.
|
r=me with those changes. |
|
@bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 13, 2017
style: Share code between Gecko and Servo for DOM APIs. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18863) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedOct 13, 2017
•
edited by SimonSapin
This change is