Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (details below): #18890

Merged
merged 1 commit into from Oct 16, 2017
Merged

Update WR (details below): #18890

merged 1 commit into from Oct 16, 2017
+87 −77

Conversation

@glennw
Copy link
Member

glennw commented Oct 16, 2017 •
edited by SimonSapin

  • Add support for clip masks on text runs.
  • Fix atomic ordering of items with multiple shadows.
  • Update to bincode + ipc-channel with optimizations.
  • Fix some plane splitting precision errors.
  • Improve the anti-aliasing quality significantly.
  • Add internal ClipChain support.
  • Fix diacritic glyphs on Linux.

This change is Reviewable
@highfive
Copy link

highfive commented Oct 16, 2017

Heads up! This PR modifies the following files:

  • @jgraham: components/webdriver_server/Cargo.toml
  • @emilio: components/layout/display_list_builder.rs, components/layout/webrender_helpers.rs, components/layout/Cargo.toml
  • @fitzgen: components/devtools_traits/Cargo.toml, components/devtools_traits/Cargo.toml, components/profile/Cargo.toml, components/profile_traits/Cargo.toml, components/profile_traits/Cargo.toml and 5 more
  • @KiChjang: components/script/Cargo.toml, components/net/Cargo.toml, components/script_layout_interface/Cargo.toml, components/net_traits/Cargo.toml, components/net_traits/Cargo.toml and 2 more
  • @asajeffrey: components/constellation/Cargo.toml, components/webdriver_server/Cargo.toml
  • @paulrouget: components/servo/Cargo.toml, components/compositing/Cargo.toml, components/constellation/Cargo.toml
@glennw
Copy link
Member Author

glennw commented Oct 16, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

⌛ Trying commit 6b6f3c4 with merge 97c7908...
bors-servo added a commit that referenced this pull request Oct 16, 2017
@bors-servo
Auto merge of #18890 - glennw:update-wr-clip-text-aa, r=<try>
Loading status checks…
97c7908 
Update WR (details below):

* Add support for clip masks on text runs.
* Fix atomic ordering of items with multiple shadows.
* Update to bincode + ipc-channel with optimizations.
* Fix some plane splitting precision errors.
* Improve the anti-aliasing quality significantly.
* Add internal ClipChain support.
* Fix diacritic glyphs on Linux.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

💔 Test failed - linux-rel-css
@glennw glennw force-pushed the glennw:update-wr-clip-text-aa branch from 6b6f3c4 to 7366bf5 Oct 16, 2017
@glennw
Copy link
Member Author

glennw commented Oct 16, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

⌛ Trying commit 7366bf5 with merge c193fa9...
bors-servo added a commit that referenced this pull request Oct 16, 2017
@bors-servo
Auto merge of #18890 - glennw:update-wr-clip-text-aa, r=<try>
Loading status checks…
c193fa9 
Update WR (details below):

* Add support for clip masks on text runs.
* Fix atomic ordering of items with multiple shadows.
* Update to bincode + ipc-channel with optimizations.
* Fix some plane splitting precision errors.
* Improve the anti-aliasing quality significantly.
* Add internal ClipChain support.
* Fix diacritic glyphs on Linux.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18890)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

💔 Test failed - mac-rel-css1
@glennw glennw force-pushed the glennw:update-wr-clip-text-aa branch from 7366bf5 to d8dd854 Oct 16, 2017
@glennw
Copy link
Member Author

glennw commented Oct 16, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

⌛ Trying commit d8dd854 with merge 5333887...
bors-servo added a commit that referenced this pull request Oct 16, 2017
@bors-servo
Auto merge of #18890 - glennw:update-wr-clip-text-aa, r=<try>
Loading status checks…
5333887 
Update WR (details below):

* Add support for clip masks on text runs.
* Fix atomic ordering of items with multiple shadows.
* Update to bincode + ipc-channel with optimizations.
* Fix some plane splitting precision errors.
* Improve the anti-aliasing quality significantly.
* Add internal ClipChain support.
* Fix diacritic glyphs on Linux.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18890)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

💔 Test failed - mac-rel-css2
@glennw glennw force-pushed the glennw:update-wr-clip-text-aa branch from d8dd854 to e8582cb Oct 16, 2017
@glennw
Copy link
Member Author

glennw commented Oct 16, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

⌛ Trying commit e8582cb with merge 720f645...
bors-servo added a commit that referenced this pull request Oct 16, 2017
@bors-servo
Auto merge of #18890 - glennw:update-wr-clip-text-aa, r=<try>
Loading status checks…
720f645 
Update WR (details below):

* Add support for clip masks on text runs.
* Fix atomic ordering of items with multiple shadows.
* Update to bincode + ipc-channel with optimizations.
* Fix some plane splitting precision errors.
* Improve the anti-aliasing quality significantly.
* Add internal ClipChain support.
* Fix diacritic glyphs on Linux.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18890)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True
@glennw
Copy link
Member Author

glennw commented Oct 16, 2017

There are two new failures in this WR update.

They are caused by servo/webrender#1776, which is being exposed by the vast improvements to anti-aliasing landed in servo/webrender#1822.

r? @jdm or @emilio
@emilio
emilio approved these changes Oct 16, 2017
View changes
...ing-1_dev/html/mix-blend-mode-intermediate-element-overflow-hidden-and-border-radius.htm.ini
@@ -0,0 +1,5 @@
[mix-blend-mode-intermediate-element-overflow-hidden-and-border-radius.htm]
type: reftest

This comment has been minimized.

Sign in to view
@emilio

emilio Oct 16, 2017

Member

Can you add a bug: <link-to-issue> entry here?
tests/wpt/metadata-css/css-transforms-1_dev/html/transform-3d-rotateY-stair-below-001.htm.ini
@@ -0,0 +1,3 @@
[transform-3d-rotateY-stair-below-001.htm]
type: reftest

This comment has been minimized.

Sign in to view
@emilio

emilio Oct 16, 2017

Member

Same here.
@gw3583
Update WR (details below):
Loading status checks…
4469f39 
* Add support for clip masks on text runs.
* Fix atomic ordering of items with multiple shadows.
* Update to bincode + ipc-channel with optimizations.
* Fix some plane splitting precision errors.
* Improve the anti-aliasing quality significantly.
* Add internal ClipChain support.
* Fix diacritic glyphs on Linux.
@glennw glennw force-pushed the glennw:update-wr-clip-text-aa branch from e8582cb to 4469f39 Oct 16, 2017
@glennw
Copy link
Member Author

glennw commented Oct 16, 2017

Sure, done.
@jdm
Copy link
Member

jdm commented Oct 16, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

📌 Commit 4469f39 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

⌛ Testing commit 4469f39 with merge d3d2b02...
bors-servo added a commit that referenced this pull request Oct 16, 2017
@bors-servo
Auto merge of #18890 - glennw:update-wr-clip-text-aa, r=jdm
Loading status checks…
d3d2b02 
Update WR (details below):

* Add support for clip masks on text runs.
* Fix atomic ordering of items with multiple shadows.
* Update to bincode + ipc-channel with optimizations.
* Fix some plane splitting precision errors.
* Improve the anti-aliasing quality significantly.
* Add internal ClipChain support.
* Fix diacritic glyphs on Linux.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18890)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing d3d2b02 to master...
@bors-servo bors-servo mentioned this pull request Oct 16, 2017
Merged
3 of 5 tasks complete
@bors-servo bors-servo merged commit 4469f39 into servo:master Oct 16, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 16, 2017
Merged
0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@glennw @highfive @bors-servo @jdm @emilio @gw3583
You can’t perform that action at this time.