style: Remove TNode::set_can_be_fragmented and TNode::can_be_fragmented. #18893

emilio · 2017-10-16T11:14:17Z

Replace them instead by a computed value flag, the same way as the
IS_IN_DISPLAY_NONE_SUBTREE flag works.

This change is

highfive · 2017-10-16T11:14:21Z

Heads up! This PR modifies the following files:

@bholley: components/style/properties/gecko.mako.rs, components/style/style_adjuster.rs, components/style/dom.rs, components/style/gecko/wrapper.rs, components/style/properties/computed_value_flags.rs and 2 more
@canaltinova: components/style/properties/gecko.mako.rs, components/style/style_adjuster.rs, components/style/dom.rs, components/style/gecko/wrapper.rs, components/style/properties/computed_value_flags.rs and 2 more
@fitzgen: components/script/lib.rs, components/script/dom/node.rs, components/script_layout_interface/wrapper_traits.rs
@KiChjang: components/script/lib.rs, components/script/dom/node.rs, components/script_layout_interface/wrapper_traits.rs

highfive · 2017-10-16T11:14:23Z

Warning

These commits modify style, layout, and script code, but no tests are modified. Please consider adding a test!

emilio · 2017-10-16T11:14:24Z

r? @SimonSapin

emilio · 2017-10-16T11:14:30Z

@bors-servo try

bors-servo · 2017-10-16T11:14:34Z

⌛ Trying commit 871a016 with merge ec1164f...


        Auto merge of #18893 - emilio:bye-can-be-fragmented, r=<try>

style: Remove TNode::set_can_be_fragmented and TNode::can_be_fragmented. Replace them instead by a computed value flag, the same way as the IS_IN_DISPLAY_NONE_SUBTREE flag works.

emilio · 2017-10-16T11:53:38Z

@bors-servo try

Now passing tidy

bors-servo · 2017-10-16T11:53:43Z

⌛ Trying commit 78a4194 with merge dff6474...


        Auto merge of #18893 - emilio:bye-can-be-fragmented, r=<try>

style: Remove TNode::set_can_be_fragmented and TNode::can_be_fragmented. Replace them instead by a computed value flag, the same way as the IS_IN_DISPLAY_NONE_SUBTREE flag works.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18893)

bors-servo · 2017-10-16T13:32:01Z

💔 Test failed - linux-rel-css

jdm · 2017-10-16T13:39:00Z

  ▶ FAIL [expected PASS] /css-flexbox-1_dev/html/flexbox_columns.htm
  └   → /css-flexbox-1_dev/html/flexbox_columns.htm e038cebd05342d3dd4d4ddc05038107516f916c4
/css-flexbox-1_dev/html/reference/flexbox_columns-ref.htm b162d7afebb1dac86e4f86aae00e6a06654fd405
Testing e038cebd05342d3dd4d4ddc05038107516f916c4 == b162d7afebb1dac86e4f86aae00e6a06654fd405

emilio · 2017-10-16T13:55:23Z

@bors-servo retry

bors-servo · 2017-10-16T13:55:29Z

⌛ Trying commit 78a4194 with merge 2bef97c...


        Auto merge of #18893 - emilio:bye-can-be-fragmented, r=<try>

style: Remove TNode::set_can_be_fragmented and TNode::can_be_fragmented. Replace them instead by a computed value flag, the same way as the IS_IN_DISPLAY_NONE_SUBTREE flag works.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18893)

SimonSapin · 2017-10-16T14:11:56Z

@bors-servo r+

Reviewed 14 of 14 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

bors-servo · 2017-10-16T14:11:57Z

📌 Commit 78a4194 has been approved by SimonSapin

emilio · 2017-10-16T19:01:47Z

@bors-servo p=1

bors-servo · 2017-10-16T19:44:11Z

⌛ Testing commit 78a4194 with merge a90280d...


        Auto merge of #18893 - emilio:bye-can-be-fragmented, r=SimonSapin

style: Remove TNode::set_can_be_fragmented and TNode::can_be_fragmented. Replace them instead by a computed value flag, the same way as the IS_IN_DISPLAY_NONE_SUBTREE flag works.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18893)

bors-servo · 2017-10-16T20:36:39Z

💔 Test failed - mac-rel-css1

emilio · 2018-01-04T18:48:16Z

@bors-servo try

bors-servo · 2018-01-04T18:52:01Z

⌛ Trying commit 3bbd80d with merge 1dfc856...


        Auto merge of #18893 - emilio:bye-can-be-fragmented, r=<try>

style: Remove TNode::set_can_be_fragmented and TNode::can_be_fragmented. Replace them instead by a computed value flag, the same way as the IS_IN_DISPLAY_NONE_SUBTREE flag works.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18893)

bors-servo · 2018-01-04T18:56:53Z

💔 Test failed - mac-rel-wpt2

emilio · 2018-01-04T19:10:53Z

@bors-servo retry

bors-servo · 2018-01-04T19:10:58Z

⌛ Trying commit 3bbd80d with merge 30586fd...


        Auto merge of #18893 - emilio:bye-can-be-fragmented, r=<try>

style: Remove TNode::set_can_be_fragmented and TNode::can_be_fragmented. Replace them instead by a computed value flag, the same way as the IS_IN_DISPLAY_NONE_SUBTREE flag works.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18893)

bors-servo · 2018-01-04T19:51:03Z

💔 Test failed - mac-rel-wpt4

jdm · 2018-01-04T20:04:45Z

  ▶ FAIL [expected PASS] /css/css-flexbox/flexbox_columns.html
  └   → /css/css-flexbox/flexbox_columns.html e038cebd05342d3dd4d4ddc05038107516f916c4
/css/css-flexbox/flexbox_columns-ref.html b162d7afebb1dac86e4f86aae00e6a06654fd405
Testing e038cebd05342d3dd4d4ddc05038107516f916c4 == b162d7afebb1dac86e4f86aae00e6a06654fd405

This consistently fails.

emilio · 2018-01-04T20:09:35Z

@SimonSapin I can't repro that test failure, and I'm pretty confident that if it was passing before it was just by chance. In any case, this is the right thing to do, as of right now Servo doesn't propagate the can_be_fragmented bit in any sort of right way, and this patch fixes it.

Mind if I land it with that test marked as failing?

SimonSapin · 2018-01-05T10:22:25Z

It indeed sounds likely that flexbox+multicol doesn’t actually work well together today. Making as failing sounds fine.


        Mark flexbox_columns.html as failing.

If it was passing before this patch, it was just by chance, and I can't repro the failure.

emilio · 2018-01-05T11:10:56Z

@bors-servo r=SimonSapin

bors-servo · 2018-01-05T11:10:57Z

📌 Commit 4ee9822 has been approved by SimonSapin

bors-servo · 2018-01-05T11:11:01Z

⌛ Testing commit 4ee9822 with merge 83a8891...


        Auto merge of #18893 - emilio:bye-can-be-fragmented, r=SimonSapin

style: Remove TNode::set_can_be_fragmented and TNode::can_be_fragmented. Replace them instead by a computed value flag, the same way as the IS_IN_DISPLAY_NONE_SUBTREE flag works.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18893)

bors-servo · 2018-01-05T12:37:33Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing 83a8891 to master...

highfive assigned mbrubeck Oct 16, 2017

highfive added the S-awaiting-review label Oct 16, 2017

highfive assigned SimonSapin and unassigned mbrubeck Oct 16, 2017

emilio force-pushed the emilio:bye-can-be-fragmented branch from 871a016 to 78a4194 Oct 16, 2017

highfive added the S-tests-failed label Oct 16, 2017

highfive added S-awaiting-merge and removed S-awaiting-review S-tests-failed labels Oct 16, 2017

highfive removed the S-awaiting-merge label Oct 16, 2017

highfive added the S-tests-failed label Jan 4, 2018

emilio force-pushed the emilio:bye-can-be-fragmented branch from 20918aa to 3bbd80d Jan 4, 2018

highfive removed the S-tests-failed label Jan 4, 2018

highfive added the S-tests-failed label Jan 4, 2018

Mark flexbox_columns.html as failing.

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

Loading status checks…

4ee9822

If it was passing before this patch, it was just by chance, and I can't repro the failure.

highfive removed the S-tests-failed label Jan 5, 2018

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Jan 5, 2018

highfive removed the S-awaiting-merge label Jan 5, 2018

emilio deleted the emilio:bye-can-be-fragmented branch Jan 5, 2018

emilio mentioned this pull request Jan 22, 2018

assertion failed: FlowRef::get_mut(&mut this).is_some() #18544

Closed

servo / servo

style: Remove TNode::set_can_be_fragmented and TNode::can_be_fragmented. #18893

style: Remove TNode::set_can_be_fragmented and TNode::can_be_fragmented. #18893

emilio commented Oct 16, 2017 •

edited by SimonSapin

highfive commented Oct 16, 2017

highfive commented Oct 16, 2017

emilio commented Oct 16, 2017

emilio commented Oct 16, 2017

bors-servo commented Oct 16, 2017

emilio commented Oct 16, 2017

bors-servo commented Oct 16, 2017

bors-servo commented Oct 16, 2017

jdm commented Oct 16, 2017

emilio commented Oct 16, 2017

bors-servo commented Oct 16, 2017

SimonSapin commented Oct 16, 2017

bors-servo commented Oct 16, 2017

emilio commented Oct 16, 2017

bors-servo commented Oct 16, 2017

bors-servo commented Oct 16, 2017

emilio commented Jan 4, 2018 •

edited

bors-servo commented Jan 4, 2018

bors-servo commented Jan 4, 2018

emilio commented Jan 4, 2018

bors-servo commented Jan 4, 2018

bors-servo commented Jan 4, 2018

jdm commented Jan 4, 2018

emilio commented Jan 4, 2018

SimonSapin commented Jan 5, 2018

emilio commented Jan 5, 2018

bors-servo commented Jan 5, 2018

bors-servo commented Jan 5, 2018

bors-servo commented Jan 5, 2018

servo / servo

Join GitHub today

style: Remove TNode::set_can_be_fragmented and TNode::can_be_fragmented. #18893

style: Remove TNode::set_can_be_fragmented and TNode::can_be_fragmented. #18893

Conversation

emilio commented Oct 16, 2017 • edited by SimonSapin

highfive commented Oct 16, 2017

highfive commented Oct 16, 2017

emilio commented Oct 16, 2017

emilio commented Oct 16, 2017

bors-servo commented Oct 16, 2017

emilio commented Oct 16, 2017

bors-servo commented Oct 16, 2017

bors-servo commented Oct 16, 2017

jdm commented Oct 16, 2017

emilio commented Oct 16, 2017

bors-servo commented Oct 16, 2017

SimonSapin commented Oct 16, 2017

bors-servo commented Oct 16, 2017

emilio commented Oct 16, 2017

bors-servo commented Oct 16, 2017

bors-servo commented Oct 16, 2017

emilio commented Jan 4, 2018 • edited

bors-servo commented Jan 4, 2018

bors-servo commented Jan 4, 2018

emilio commented Jan 4, 2018

bors-servo commented Jan 4, 2018

bors-servo commented Jan 4, 2018

jdm commented Jan 4, 2018

emilio commented Jan 4, 2018

SimonSapin commented Jan 5, 2018

emilio commented Jan 5, 2018

bors-servo commented Jan 5, 2018

bors-servo commented Jan 5, 2018

bors-servo commented Jan 5, 2018

emilio commented Oct 16, 2017 •

edited by SimonSapin

emilio commented Jan 4, 2018 •

edited