Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of unstable box syntax. #18900

Merged
merged 1 commit into from Oct 16, 2017
Merged

Remove use of unstable box syntax. #18900

merged 1 commit into from Oct 16, 2017

Commits on Oct 16, 2017

  1. Remove use of unstable box syntax.

    http://www.robohornet.org gives a score of 101.36 on master,
    and 102.68 with this PR. The latter is slightly better,
    but probably within noise level.
    So it looks like this PR does not affect DOM performance.
    
    This is expected since `Box::new` is defined as:
    
    ```rust
    impl<T> Box<T> {
        #[inline(always)]
        pub fn new(x: T) -> Box<T> {
            box x
        }
    }
    ```
    
    With inlining, it should compile to the same as box syntax.
    SimonSapin committed Oct 16, 2017
You can’t perform that action at this time.