Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate CEF builds #18907

Merged
merged 1 commit into from Oct 17, 2017

Conversation

@jdm
Copy link
Member

commented Oct 16, 2017

We already run ./mach build-cef on mac-dev-unit and linux-dev. These tasks take an extra 20 minutes on some of our longest-running builders, so this is an easy win.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Oct 16, 2017

Heads up! This PR modifies the following files:

@SimonSapin

This comment has been minimized.

Copy link
Member

commented Oct 17, 2017

This means compiling fewer CEF combinations of debug/release and debug_assertions. But I think we can live with that.

@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

📌 Commit d923fb9 has been approved by SimonSapin

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

⌛️ Testing commit d923fb9 with merge 73412ee...

bors-servo added a commit that referenced this pull request Oct 17, 2017
Remove duplicate CEF builds

We already run `./mach build-cef` on `mac-dev-unit` and `linux-dev`. These tasks take an extra 20 minutes on some of our longest-running builders, so this is an easy win.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18907)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

💔 Test failed - mac-rel-wpt1

@jdm

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2017

@bors-servo: retry

  • timeout while building
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

⌛️ Testing commit d923fb9 with merge 0d6e5ec...

bors-servo added a commit that referenced this pull request Oct 17, 2017
Remove duplicate CEF builds

We already run `./mach build-cef` on `mac-dev-unit` and `linux-dev`. These tasks take an extra 20 minutes on some of our longest-running builders, so this is an easy win.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18907)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

💔 Test failed - linux-rel-css

@jdm

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

⌛️ Testing commit d923fb9 with merge d36483a...

bors-servo added a commit that referenced this pull request Oct 17, 2017
Remove duplicate CEF builds

We already run `./mach build-cef` on `mac-dev-unit` and `linux-dev`. These tasks take an extra 20 minutes on some of our longest-running builders, so this is an easy win.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18907)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

💔 Test failed - mac-rel-wpt1

@jdm

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2017

@bors-servo: retry

  • twisted connection failure???
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

⌛️ Testing commit d923fb9 with merge 00e2a1c...

bors-servo added a commit that referenced this pull request Oct 17, 2017
Remove duplicate CEF builds

We already run `./mach build-cef` on `mac-dev-unit` and `linux-dev`. These tasks take an extra 20 minutes on some of our longest-running builders, so this is an easy win.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18907)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

@bors-servo bors-servo merged commit d923fb9 into master Oct 17, 2017
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the jdm-patch-3 branch Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.