Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Add some more tests for disallowed rootMargin values. #18917

Merged
merged 1 commit into from Oct 17, 2017

Conversation

@heycam
Copy link
Member

commented Oct 17, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Oct 17, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/specified/gecko.rs
  • @canaltinova: components/style/values/specified/gecko.rs
  • @emilio: components/style/values/specified/gecko.rs
@heycam

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2017

r? @emilio

@highfive highfive assigned emilio and unassigned KiChjang Oct 17, 2017
@emilio
emilio approved these changes Oct 17, 2017
@emilio

This comment has been minimized.

Copy link
Member

commented Oct 17, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

📌 Commit 854a747 has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

⌛️ Testing commit 854a747 with merge 68d1623...

bors-servo added a commit that referenced this pull request Oct 17, 2017
style: Add some more tests for disallowed rootMargin values.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18917)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

💔 Test failed - android

@heycam heycam force-pushed the heycam:observer-test branch from 854a747 to 97f619e Oct 17, 2017
@heycam

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

📌 Commit 97f619e has been approved by emilio

@@ -35,6 +35,18 @@
test(function () {
assert_throws("SYNTAX_ERR", function() {
new IntersectionObserver(e => {}, {rootMargin: "calc(1px + 2px)"})
})
}, 'IntersectionObserver constructor width { rootMargin: "calc(1px + 2px)" }');

This comment has been minimized.

Copy link
@emilio

emilio Oct 17, 2017

Member

nit: This should probably be with instead of width, same below.

@heycam heycam force-pushed the heycam:observer-test branch from 97f619e to e5eac62 Oct 17, 2017
@heycam

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

📌 Commit e5eac62 has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

⌛️ Testing commit e5eac62 with merge 56e5d56...

bors-servo added a commit that referenced this pull request Oct 17, 2017
style: Add some more tests for disallowed rootMargin values.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18917)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

💔 Test failed - android

@jdm

This comment has been minimized.

Copy link
Member

commented Oct 17, 2017

Needs a ./mach update-manifest.

@emilio emilio force-pushed the heycam:observer-test branch from e5eac62 to 893415c Oct 17, 2017
@emilio

This comment has been minimized.

Copy link
Member

commented Oct 17, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

📌 Commit 893415c has been approved by emilio

@emilio

This comment has been minimized.

Copy link
Member

commented Oct 17, 2017

(Just did that)

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

⌛️ Testing commit 893415c with merge aa3122e...

bors-servo added a commit that referenced this pull request Oct 17, 2017
style: Add some more tests for disallowed rootMargin values.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18917)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

@bors-servo bors-servo merged commit 893415c into servo:master Oct 17, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
jdm added a commit to web-platform-tests/wpt that referenced this pull request Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.