Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unused warning #18919

Merged
merged 1 commit into from Oct 17, 2017
Merged

fix unused warning #18919

merged 1 commit into from Oct 17, 2017

Conversation

@tigercosmos
Copy link
Collaborator

tigercosmos commented Oct 17, 2017 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #18916
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@tigercosmos
fix unused warning
Loading status checks…
d5f5691
@highfive
Copy link

highfive commented Oct 17, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/element.rs
  • @KiChjang: components/script/dom/element.rs
@highfive
Copy link

highfive commented Oct 17, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@SimonSapin
Copy link
Member

SimonSapin commented Oct 17, 2017

@bors-servo r+

Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

📌 Commit d5f5691 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

⌛ Testing commit d5f5691 with merge 7704fa0...
bors-servo added a commit that referenced this pull request Oct 17, 2017
@bors-servo
Auto merge of #18919 - tigercosmos:remove, r=SimonSapin
Loading status checks…
7704fa0 
fix unused warning

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18916

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18919)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing 7704fa0 to master...
@bors-servo bors-servo merged commit d5f5691 into servo:master Oct 17, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 17, 2017
Merged
3 of 3 tasks complete
@tigercosmos tigercosmos deleted the tigercosmos:remove branch Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

unused import
4 participants
@tigercosmos @highfive @SimonSapin @bors-servo
You can’t perform that action at this time.