Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commonmark Markdown warnings in docs, part 1 #18924

Merged
merged 1 commit into from Oct 17, 2017
Merged

Fix commonmark Markdown warnings in docs, part 1 #18924

merged 1 commit into from Oct 17, 2017
+572 −565

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Oct 17, 2017 •
edited by SimonSapin

Fixes warnings from rust-lang/rust#44229 when --enable-commonmark is passed to rustdoc.

This is mostly a global find-and-replace for bare URIs on lines by themselves in doc comments.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because they are doc formatting changes only

This change is Reviewable
@mbrubeck
Fix commonmark Markdown warnings in docs, part 1
Loading status checks…
efc3683 
Fixes warnings from rust-lang/rust#44229 when `--enable-commonmark` is
passed to rustdoc.

This is mostly a global find-and-replace for bare URIs on lines by
themselves in doc comments.
@highfive
Copy link

highfive commented Oct 17, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/selectors/build.rs, components/style/dom_apis.rs, components/style/stylesheets/origin.rs, components/style/values/computed/length.rs, components/style/values/generics/grid.rs and 46 more
  • @canaltinova: components/style/dom_apis.rs, components/style/stylesheets/origin.rs, components/style/values/computed/length.rs, components/style/values/generics/grid.rs, components/style/values/generics/basic_shape.rs and 43 more
  • @wafflespeanut: python/tidy/servo_tidy_tests/speclink.rs, python/tidy/servo_tidy/tidy.py
  • @emilio: components/style/dom_apis.rs, components/style/stylesheets/origin.rs, components/style/values/computed/length.rs, components/style/values/generics/grid.rs, components/style/values/generics/basic_shape.rs and 47 more
  • @fitzgen: components/script/dom/blob.rs, components/script/textinput.rs, components/script_traits/lib.rs, components/script_traits/lib.rs, components/script/dom/eventtarget.rs and 60 more
  • @KiChjang: components/script/dom/blob.rs, components/script/textinput.rs, components/script_traits/lib.rs, components/script_traits/lib.rs, components/script/dom/eventtarget.rs and 75 more
  • @asajeffrey: components/constellation/browsingcontext.rs, components/constellation/event_loop.rs
  • @edunham: python/tidy/servo_tidy_tests/speclink.rs, python/tidy/servo_tidy/tidy.py
  • @paulrouget: components/servo_arc/lib.rs, components/compositing/compositor.rs, components/constellation/browsingcontext.rs, components/constellation/event_loop.rs
@highfive
Copy link

highfive commented Oct 17, 2017

warning Warning warning

  • These commits modify style, layout, net, and script code, but no tests are modified. Please consider adding a test!
@Manishearth
Manishearth approved these changes Oct 17, 2017
View changes
Copy link
Member

Manishearth left a comment

r=me
@KiChjang
Copy link
Member

KiChjang commented Oct 17, 2017

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

📌 Commit efc3683 has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned jdm Oct 17, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

⌛ Testing commit efc3683 with merge 0e62a58...
bors-servo added a commit that referenced this pull request Oct 17, 2017
@bors-servo
Auto merge of #18924 - mbrubeck:doc, r=Manishearth
Loading status checks…
0e62a58 
Fix commonmark Markdown warnings in docs, part 1

Fixes warnings from rust-lang/rust#44229 when `--enable-commonmark` is passed to rustdoc.

This is mostly a global find-and-replace for bare URIs on lines by themselves in doc comments.

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they are doc formatting changes only

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18924)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: Manishearth
Pushing 0e62a58 to master...
@bors-servo bors-servo merged commit efc3683 into servo:master Oct 17, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Oct 17, 2017
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@mbrubeck @highfive @KiChjang @bors-servo @Manishearth @jdm
You can’t perform that action at this time.