Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up llvm for osmesa. #18955

Merged
merged 1 commit into from Oct 20, 2017
Merged

Set up llvm for osmesa. #18955

merged 1 commit into from Oct 20, 2017

Conversation

@jdm
Copy link
Member

jdm commented Oct 19, 2017 •
edited

This fixes #18954.

This change is Reviewable
@jdm
Set up llvm for osmesa.
Loading status checks…
4451a35
@highfive
Copy link

highfive commented Oct 19, 2017

Heads up! This PR modifies the following files:
@jdm
Copy link
Member Author

jdm commented Oct 19, 2017

@bors-servo: r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Oct 19, 2017

📌 Commit 4451a35 has been approved by emilio
@Nashenas88
Copy link

Nashenas88 commented Oct 20, 2017

@jdm will this require a change to the build instructions in the README.md as well? I just did a test build on a new ubuntu machine and it broke.
@emilio
Copy link
Member

emilio commented Oct 20, 2017

@Nashenas88 what does the failure look like? Can you file an issue?

@bors-servo p=1
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2017

⌛ Testing commit 4451a35 with merge 5d16c73...
bors-servo added a commit that referenced this pull request Oct 20, 2017
@bors-servo
Auto merge of #18955 - servo:jdm-patch-4, r=emilio
Loading status checks…
5d16c73 
Set up llvm for osmesa.

This fixes #18954.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18955)
<!-- Reviewable:end -->
@SimonSapin
SimonSapin reviewed Oct 20, 2017
View changes
.travis.yml
@@ -12,6 +12,12 @@ matrix:
cache: false
- sudo: 9000
dist: trusty
before_install:
- sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y
- sudo add-apt-repository 'deb http://apt.llvm.org/precise/ llvm-toolchain-precise-3.9 main' -y

This comment has been minimized.

Sign in to view
@SimonSapin

SimonSapin Oct 20, 2017

Member

This should likely be trusty instead of precise, since we have dist: trusty in the same file.
SimonSapin added a commit to servo/servo-with-rust-nightly that referenced this pull request Oct 20, 2017
@SimonSapin
Set up LLVM for OSMesa
Loading status checks…
74bc68e 
servo/servo#18955
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 5d16c73 to master...
@bors-servo bors-servo merged commit 4451a35 into master Oct 20, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
SimonSapin added a commit to servo/servo-with-rust-nightly that referenced this pull request Oct 20, 2017
@SimonSapin
Set up LLVM for OSMesa
Loading status checks…
05aff36 
servo/servo#18955
@SimonSapin SimonSapin deleted the jdm-patch-4 branch Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonSapin SimonSapin

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

TravisCI is broken since osmesa update
6 participants
@jdm @highfive @bors-servo @Nashenas88 @emilio @SimonSapin
You can’t perform that action at this time.