Update WR (box shadows + per-corner radii, elliptical clips). #18956

glennw · 2017-10-19T21:43:51Z

This change is

highfive · 2017-10-19T21:43:54Z

Heads up! This PR modifies the following files:

@emilio: components/layout/webrender_helpers.rs, components/layout/display_list_builder.rs

highfive · 2017-10-19T21:43:55Z

Warning

These commits modify gfx and layout code, but no tests are modified. Please consider adding a test!

glennw · 2017-10-19T21:44:00Z

@bors-servo try

bors-servo · 2017-10-19T21:44:05Z

⌛ Trying commit ae831ea with merge bcfaa77...


        Auto merge of #18956 - glennw:update-wr-ellipse-bs, r=<try>

Update WR (box shadows + per-corner radii, elliptical clips).

bors-servo · 2017-10-19T22:14:36Z

💔 Test failed - linux-rel-css

glennw · 2017-10-19T22:52:59Z

@bors-servo retry

infra issue?

bors-servo · 2017-10-19T22:53:03Z

⌛ Trying commit ae831ea with merge 6774bc3...


        Auto merge of #18956 - glennw:update-wr-ellipse-bs, r=<try>

Update WR (box shadows + per-corner radii, elliptical clips).  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18956)

bors-servo · 2017-10-19T23:28:51Z

⛄ The build was interrupted to prioritize another pull request.

bors-servo · 2017-10-19T23:28:56Z

⌛ Trying commit ae831ea with merge 57e411b...


        Auto merge of #18956 - glennw:update-wr-ellipse-bs, r=<try>

Update WR (box shadows + per-corner radii, elliptical clips).  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18956)

bors-servo · 2017-10-19T23:30:38Z

⛄ The build was interrupted to prioritize another pull request.

bors-servo · 2017-10-19T23:30:42Z

⌛ Trying commit ae831ea with merge 31575d3...


        Auto merge of #18956 - glennw:update-wr-ellipse-bs, r=<try>

Update WR (box shadows + per-corner radii, elliptical clips).  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18956)

bors-servo · 2017-10-20T00:08:16Z

💔 Test failed - arm64

jdm · 2017-10-20T00:11:32Z

That problem will be solved by #18961.

jdm · 2017-10-20T00:53:33Z

  ▶ PASS [expected FAIL] /css-backgrounds-3_dev/html4/css-box-shadow-001.htm

glennw · 2017-10-20T00:58:11Z

@bors-servo try

bors-servo · 2017-10-20T00:58:15Z

⌛ Trying commit 8da7cc4 with merge 576cdfe...


        Auto merge of #18956 - glennw:update-wr-ellipse-bs, r=<try>

Update WR (box shadows + per-corner radii, elliptical clips).  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18956)

bors-servo · 2017-10-20T01:26:08Z

💔 Test failed - linux-dev


        Update WR (box shadows + per-corner radii, elliptical clips).

glennw · 2017-10-20T03:54:04Z

@bors-servo try

bors-servo · 2017-10-20T03:54:08Z

⌛ Trying commit aaaf644 with merge c24c6e8...


        Auto merge of #18956 - glennw:update-wr-ellipse-bs, r=<try>

Update WR (box shadows + per-corner radii, elliptical clips).  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18956)

bors-servo · 2017-10-20T06:13:19Z

💔 Test failed - linux-rel-wpt

jdm · 2017-10-20T12:55:24Z

That's #13509. Everything else passed.

jdm · 2017-10-20T12:56:05Z

@bors-servo: r+

bors-servo · 2017-10-20T12:56:06Z

📌 Commit aaaf644 has been approved by jdm

bors-servo · 2017-10-20T16:18:15Z

⌛ Testing commit aaaf644 with merge fef468e...


        Auto merge of #18956 - glennw:update-wr-ellipse-bs, r=jdm

Update WR (box shadows + per-corner radii, elliptical clips).  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18956)

bors-servo · 2017-10-20T17:32:02Z

💔 Test failed - linux-rel-wpt

jdm · 2017-10-20T17:46:23Z

@bors-servo: retry

#13480

bors-servo · 2017-10-20T21:47:32Z

⌛ Testing commit aaaf644 with merge d604270...


        Auto merge of #18956 - glennw:update-wr-ellipse-bs, r=jdm

Update WR (box shadows + per-corner radii, elliptical clips).  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18956)

bors-servo · 2017-10-20T23:52:50Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing d604270 to master...

highfive assigned jdm Oct 19, 2017

highfive added the S-awaiting-review label Oct 19, 2017

bors-servo added a commit that referenced this pull request Oct 19, 2017

Auto merge of #18956 - glennw:update-wr-ellipse-bs, r=<try>

Loading status checks…

bcfaa77

Update WR (box shadows + per-corner radii, elliptical clips).

highfive added the S-tests-failed label Oct 19, 2017

bors-servo mentioned this pull request Oct 19, 2017

Backed out changeset e64e659c077d: servo PR #18809 and revendor for r… #18960

Merged

highfive added the S-tests-failed label Oct 20, 2017

glennw force-pushed the glennw:update-wr-ellipse-bs branch from ae831ea to 8da7cc4 Oct 20, 2017

highfive removed the S-tests-failed label Oct 20, 2017

highfive added the S-tests-failed label Oct 20, 2017

Update WR (box shadows + per-corner radii, elliptical clips).

Loading status checks…

aaaf644

glennw force-pushed the glennw:update-wr-ellipse-bs branch from 8da7cc4 to aaaf644 Oct 20, 2017

highfive removed the S-tests-failed label Oct 20, 2017

highfive added the S-tests-failed label Oct 20, 2017

highfive added S-awaiting-merge and removed S-awaiting-review S-tests-failed labels Oct 20, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Oct 20, 2017

highfive added S-awaiting-merge and removed S-tests-failed labels Oct 20, 2017

bors-servo merged commit aaaf644 into servo:master Oct 20, 2017
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Oct 20, 2017

bors-servo mentioned this pull request Oct 20, 2017

Wait as late as possible to assign ClipIds #18951

Merged

3 of 5 tasks complete

servo / servo

Update WR (box shadows + per-corner radii, elliptical clips). #18956

Update WR (box shadows + per-corner radii, elliptical clips). #18956

glennw commented Oct 19, 2017 •

edited by SimonSapin

highfive commented Oct 19, 2017

highfive commented Oct 19, 2017

glennw commented Oct 19, 2017

bors-servo commented Oct 19, 2017

bors-servo commented Oct 19, 2017

glennw commented Oct 19, 2017

bors-servo commented Oct 19, 2017

bors-servo commented Oct 19, 2017

bors-servo commented Oct 19, 2017

bors-servo commented Oct 19, 2017

bors-servo commented Oct 19, 2017

bors-servo commented Oct 20, 2017

jdm commented Oct 20, 2017

jdm commented Oct 20, 2017

glennw commented Oct 20, 2017

bors-servo commented Oct 20, 2017

bors-servo commented Oct 20, 2017

glennw commented Oct 20, 2017

bors-servo commented Oct 20, 2017

bors-servo commented Oct 20, 2017

jdm commented Oct 20, 2017

jdm commented Oct 20, 2017

bors-servo commented Oct 20, 2017

bors-servo commented Oct 20, 2017

bors-servo commented Oct 20, 2017

jdm commented Oct 20, 2017

bors-servo commented Oct 20, 2017

bors-servo commented Oct 20, 2017

servo / servo

Join GitHub today

Update WR (box shadows + per-corner radii, elliptical clips). #18956

Update WR (box shadows + per-corner radii, elliptical clips). #18956

Conversation

glennw commented Oct 19, 2017 • edited by SimonSapin

highfive commented Oct 19, 2017

highfive commented Oct 19, 2017

glennw commented Oct 19, 2017

bors-servo commented Oct 19, 2017

bors-servo commented Oct 19, 2017

glennw commented Oct 19, 2017

bors-servo commented Oct 19, 2017

bors-servo commented Oct 19, 2017

bors-servo commented Oct 19, 2017

bors-servo commented Oct 19, 2017

bors-servo commented Oct 19, 2017

bors-servo commented Oct 20, 2017

jdm commented Oct 20, 2017

jdm commented Oct 20, 2017

glennw commented Oct 20, 2017

bors-servo commented Oct 20, 2017

bors-servo commented Oct 20, 2017

glennw commented Oct 20, 2017

bors-servo commented Oct 20, 2017

bors-servo commented Oct 20, 2017

jdm commented Oct 20, 2017

jdm commented Oct 20, 2017

bors-servo commented Oct 20, 2017

bors-servo commented Oct 20, 2017

bors-servo commented Oct 20, 2017

jdm commented Oct 20, 2017

bors-servo commented Oct 20, 2017

bors-servo commented Oct 20, 2017

glennw commented Oct 19, 2017 •

edited by SimonSapin