Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webrender for latest RenderNotifier changes #18976

Closed
wants to merge 1 commit into from
Closed

Update webrender for latest RenderNotifier changes #18976

wants to merge 1 commit into from
+13 −23

Conversation

@jdm
Copy link
Member

jdm commented Oct 20, 2017 •
edited by SimonSapin

This addresses one of the most common intermittent test failures by making it impossible for the failure to occur. Requires servo/webrender#1904 to be merged upstream first.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #13480
  • There are tests for these changes

This change is Reviewable
@jdm
Update webrender for latest RenderNotifier changes.
Loading status checks…
23a43eb
@highfive
Copy link

highfive commented Oct 20, 2017

Heads up! This PR modifies the following files:

  • @paulrouget: components/compositing/lib.rs, components/compositing/compositor_thread.rs, components/servo/lib.rs, components/compositing/compositor.rs
@jdm
Copy link
Member Author

jdm commented Oct 20, 2017

r? @glennw
@highfive highfive assigned glennw and unassigned cbrewster Oct 20, 2017
@glennw glennw mentioned this pull request Oct 23, 2017
Merged
@glennw
Copy link
Member

glennw commented Oct 23, 2017

@jdm I included this commit of yours in #18986 - feel free to either r+ that PR, or close that and apply the changes to this PR.
@jdm jdm closed this Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glennw glennw

Labels
S-awaiting-review S-blocked-on-external
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

intermittent crash ("Connection reset by peer" from create_api) in /html/semantics/embedded-content/the-canvas-element/2d.getcontext.shared.html, /html/semantics/scripting-1/the-template-element/template-element/node-document-changes.html, /dom/traversal/TreeWalker-walking-outside-a-tree.html, /XMLHttpRequest/responseText-status.html, /_mozilla/css/line_break_nowrap.html
4 participants
@jdm @highfive @glennw @cbrewster
You can’t perform that action at this time.