Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge request type and destination #18981

Merged
merged 1 commit into from Oct 24, 2017
Merged

Merge request type and destination #18981

merged 1 commit into from Oct 24, 2017

Conversation

@KiChjang
Copy link
Member

KiChjang commented Oct 21, 2017 •
edited by SimonSapin

Fixes #18278.

This change is Reviewable
@highfive
Copy link

highfive commented Oct 21, 2017

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/network_listener.rs
  • @paulrouget: components/constellation/network_listener.rs
  • @fitzgen: components/script/dom/request.rs, components/script/dom/webidls/Request.webidl, components/script/dom/htmlimageelement.rs, components/script/layout_image.rs, components/script/dom/workerglobalscope.rs and 7 more
  • @KiChjang: components/script/dom/request.rs, components/net/fetch/methods.rs, components/script/dom/webidls/Request.webidl, components/script/dom/htmlimageelement.rs, components/net/http_loader.rs and 12 more
@KiChjang
Copy link
Member Author

KiChjang commented Oct 21, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 21, 2017

⌛ Trying commit 6aeb237 with merge 8ac2118...
bors-servo added a commit that referenced this pull request Oct 21, 2017
@bors-servo
Auto merge of #18981 - KiChjang:fold-type-destination, r=<try>
Loading status checks…
8ac2118 
Merge request type and destination

Fixes #18278.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18981)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 21, 2017

💔 Test failed - windows-msvc-dev
@KiChjang KiChjang force-pushed the KiChjang:fold-type-destination branch from 6aeb237 to b7f918a Oct 22, 2017
@KiChjang
Copy link
Member Author

KiChjang commented Oct 22, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2017

⌛ Trying commit b7f918a with merge 6387ae4711ca247c60e3d3569a7244839ed15b06...
@KiChjang KiChjang force-pushed the KiChjang:fold-type-destination branch from b7f918a to 1750620 Oct 23, 2017
@KiChjang
Copy link
Member Author

KiChjang commented Oct 23, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2017

⌛ Trying commit 1750620 with merge a405089...
bors-servo added a commit that referenced this pull request Oct 23, 2017
@bors-servo
Auto merge of #18981 - KiChjang:fold-type-destination, r=<try>
Loading status checks…
a405089 
Merge request type and destination

Fixes #18278.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18981)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2017

💔 Test failed - linux-rel-wpt
@KiChjang KiChjang force-pushed the KiChjang:fold-type-destination branch from 1750620 to 3b8191b Oct 23, 2017
@KiChjang
Copy link
Member Author

KiChjang commented Oct 23, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2017

⌛ Trying commit 3b8191b with merge b4c01fc...
bors-servo added a commit that referenced this pull request Oct 23, 2017
@bors-servo
Auto merge of #18981 - KiChjang:fold-type-destination, r=<try>
Loading status checks…
b4c01fc 
Merge request type and destination

Fixes #18278.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18981)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2017

💔 Test failed - mac-rel-wpt3
@KiChjang KiChjang force-pushed the KiChjang:fold-type-destination branch from 3b8191b to c6bb1cb Oct 23, 2017
@KiChjang
Merge request type and destination
Loading status checks…
c6bb1cb
@KiChjang
Copy link
Member Author

KiChjang commented Oct 23, 2017

r? @jdm, should be a quick one here.
@highfive highfive assigned jdm and unassigned mbrubeck Oct 23, 2017
@jdm
Copy link
Member

jdm commented Oct 24, 2017

I want @avadacatavra to review more things, so I'm going to redirect this.
r? @avadacatavra
@highfive highfive assigned avadacatavra and unassigned jdm Oct 24, 2017
@avadacatavra
Copy link
Contributor

avadacatavra commented Oct 24, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2017

📌 Commit c6bb1cb has been approved by avadacatavra
@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2017

⌛ Testing commit c6bb1cb with merge dcd7d2f...
bors-servo added a commit that referenced this pull request Oct 24, 2017
@bors-servo
Auto merge of #18981 - KiChjang:fold-type-destination, r=avadacatavra
Loading status checks…
dcd7d2f 
Merge request type and destination

Fixes #18278.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18981)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: avadacatavra
Pushing dcd7d2f to master...
@bors-servo bors-servo merged commit c6bb1cb into servo:master Oct 24, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 24, 2017
Merged
@KiChjang KiChjang deleted the KiChjang:fold-type-destination branch Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@avadacatavra avadacatavra

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@KiChjang @highfive @bors-servo @jdm @avadacatavra @mbrubeck
You can’t perform that action at this time.