Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nsstring from gecko into servo/support/gecko/nsstring #18993

Merged
merged 1 commit into from Oct 24, 2017

Conversation

@mystor
Copy link
Contributor

mystor commented Oct 23, 2017

This is the servo side of bug 1403213.

Take 2 of #18941 which got backed out because we botched the landing of the gecko side and I wasn't able to fix it in time.


This change is Reviewable

This is the servo side of bug 1403213.

MozReview-Commit-ID: HFdQiuMnGhJ
@highfive
Copy link

highfive commented Oct 23, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/lib.rs, ports/geckolib/Cargo.toml, components/style/gecko_bindings/nsstring_vendor/Cargo.toml, components/style/gecko_bindings/nsstring_vendor/src/lib.rs
  • @canaltinova: components/style/Cargo.toml, components/style/lib.rs, components/style/gecko_bindings/nsstring_vendor/Cargo.toml, components/style/gecko_bindings/nsstring_vendor/src/lib.rs
  • @edunham: servo-tidy.toml
  • @emilio: components/style/Cargo.toml, components/style/lib.rs, ports/geckolib/Cargo.toml, components/style/gecko_bindings/nsstring_vendor/Cargo.toml, components/style/gecko_bindings/nsstring_vendor/src/lib.rs
@highfive
Copy link

highfive commented Oct 23, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@mystor
Copy link
Contributor Author

mystor commented Oct 23, 2017

r? @Manishearth
I'm going to push the patch to mozreview on the gecko side so we make sure we land the right thing this time :-).

@highfive highfive assigned Manishearth and unassigned nox Oct 23, 2017
@Manishearth
Copy link
Member

Manishearth commented Oct 23, 2017

@bors-servo delegate+ r+ p=10

@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2017

📌 Commit 2d3331f has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2017

✌️ @mystor can now approve this pull request

@mystor
Copy link
Contributor Author

mystor commented Oct 23, 2017

@bors-servo r+

I have the gecko side commits ready to land on reviewboard, so I think this'll go dandy this time :-).

@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #18994
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2017

📌 Commit 2d3331f has been approved by mystor

@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2017

Testing commit 2d3331f with merge 0e6946f...

bors-servo added a commit that referenced this pull request Oct 23, 2017
Move nsstring from gecko into servo/support/gecko/nsstring

This is the servo side of bug 1403213.

Take 2 of #18941 which got backed out because we botched the landing of the gecko side and I wasn't able to fix it in time.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18993)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2017

@bors-servo bors-servo merged commit 2d3331f into servo:master Oct 24, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.