Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added implementation for itemprop and itemtype along with test files #19038

Merged
merged 1 commit into from Nov 6, 2017

Commits on Nov 6, 2017

  1. Add implementation for itemprop and itemtype

    Created test file
    
    Added the stub methods for itemprop and itemscope
    
    Resolved html5ever dependency, added ItemScope and ItemProp attr
    
    Resolving dependency
    
    Added pref override on metadata attributes
    
    Resetting to original state due to change in requirement
    
    Reverted adding attributes
    
    1. add a customized implementation of parse_plain_attribute
    2. add the following methods to HTMLElement.webidl
    
    added itemprop and itemtype, enabled pref in test
    
    Added initial implementation for getting itemprop property values
    
    Adding the wireframe for testing
    
    Implemented function to handle itemType
    
    Corrected typo
    
    Fixed typo bug in code
    
    Handling duplicates for itemtype attribute values
    
    Added the test suite structure
    
    Added test for extra space
    
    Added test for regular test values
    
    Added test cases for Single property values
    
    Test cases to check absence of itemtype and itemprop attributes
    
    Added code to handle absence of itemtype or itemprop attributes
    
    Added shell script to run all test cases
    
    cleared up Cargo file
    
    Tidying up
    
    Removed the local test file
    
    Removed new line for test-tidy
    
    Ordered key in prefs.json
    
    Fixes for test-tidy
    
    Enabled test preferences
    
    Created test using wpt
    
    Creating WPT Tests for Regular and Single Prop Types
    
    Fixed the Regular type test
    
    Fixed tests
    
    Removed old test case metadata
    
    Incorporate review changes from PR
    
    Updated MANIFEST to sync test cases
    
    Making changed suggested in review
    
    Removed editor folding
    
    Removed unnecessary code
    
    Resolving cargo conflicts
    
    Updated PropertyNames and itemtypes implementation
    
    Trying different data in test case
    
    Updated manifest
    
    Updated code based on reviews
    vjhebbar authored and CJ8664 committed Nov 6, 2017
You can’t perform that action at this time.