Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Switch to Servo style backend for compositor animations #19042

Merged
merged 4 commits into from Oct 27, 2017
Merged

stylo: Switch to Servo style backend for compositor animations #19042

merged 4 commits into from Oct 27, 2017

Conversation

@BorisChiou
Copy link
Contributor

BorisChiou commented Oct 27, 2017 •
edited

These are inter-dependent patches for bug 1340005. We add two FFIs to create the
AnimationValues of Opacity and Transform because we support these two properties
on the compositor. Besides, we factor out some common functions in glue.rs, so we
can use the same code path for both main-thread and compositor-thread animations.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix Bug 1340005.
  • These changes do not require tests because we have automatic test coverage on Gecko already, and Servo doesn't support compositor animation for now.

This change is Reviewable
BorisChiou added 4 commits Oct 27, 2017
@BorisChiou
Add Servo_AnimationValue_Opacity which creates an AnimationValue of o…
f02bd01 
…pacity.
@BorisChiou
Add Servo_AnimationValue_Transform which creates an AnimationValue of…
1f5551c 
… transform.
@BorisChiou
Add Servo_ComposeAnimationSegment which composes an animation segment.
52c81a0
@BorisChiou
Handle rotate, rotate{x|y|z}, and skew{x|y} properly when cloning tra…
Loading status checks…
3a29c63 
…nsforms.
@highfive
Copy link

highfive commented Oct 27, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, components/style/gecko_bindings/sugar/ns_css_value.rs, ports/geckolib/glue.rs, components/style/properties/gecko.mako.rs
  • @canaltinova: components/style/gecko/generated/bindings.rs, components/style/gecko_bindings/sugar/ns_css_value.rs, components/style/properties/gecko.mako.rs
  • @emilio: components/style/gecko/generated/bindings.rs, components/style/gecko_bindings/sugar/ns_css_value.rs, ports/geckolib/glue.rs, components/style/properties/gecko.mako.rs
@highfive
Copy link

highfive commented Oct 27, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@BorisChiou
Copy link
Contributor Author

BorisChiou commented Oct 27, 2017

Those patches are reviewed by @birtles and @hiikezoe.
@BorisChiou
Copy link
Contributor Author

BorisChiou commented Oct 27, 2017

@bors-servo p=10

Hope I can land this ASAP.
@BorisChiou
Copy link
Contributor Author

BorisChiou commented Oct 27, 2017

@bors-servo try

Gecko try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=47c56f2700ce
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2017

⌛ Trying commit 3a29c63 with merge 4e2c0e3...
bors-servo added a commit that referenced this pull request Oct 27, 2017
@bors-servo
Auto merge of #19042 - BorisChiou:stylo/animation/compositor, r=<try>
Loading status checks…
4e2c0e3 
stylo: Switch to Servo style backend for compositor animations

These are inter-dependent patches for bug 1340005. We add two FFIs to create the
AnimationValues of Opacity and Transform because we support these two properties
on the compositor. Besides, we factor out some common function in glue.rs, so we
can use the same code path for both main-thread and compositor-thread animations.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1340005](https://bugzilla.mozilla.org/show_bug.cgi?id=1340005).
- [X] These changes do not require tests because we have automatic test coverage on Gecko already, and Servo doesn't support compositor animation for now.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19042)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2017

💔 Test failed - linux-rel-wpt
@BorisChiou
Copy link
Contributor Author

BorisChiou commented Oct 27, 2017

@bors-servo r=birtles, hiro
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2017

📌 Commit 3a29c63 has been approved by birtles,
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3...
@BorisChiou
Copy link
Contributor Author

BorisChiou commented Oct 27, 2017

@bors-servo r-
@BorisChiou
Copy link
Contributor Author

BorisChiou commented Oct 27, 2017

@bors-servo r=birtles,hiro
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2017

📌 Commit 3a29c63 has been approved by birtles,hiro
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2017

💔 Test failed - mac-rel-wpt3
@BorisChiou
Copy link
Contributor Author

BorisChiou commented Oct 27, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt3...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: birtles,hiro
Pushing 4e2c0e3 to master...
@bors-servo bors-servo merged commit 3a29c63 into servo:master Oct 27, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@BorisChiou @highfive @bors-servo @pcwalton
You can’t perform that action at this time.