Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bindgen to 0.31 #19043

Closed
wants to merge 1 commit into from
Closed

Bump bindgen to 0.31 #19043

wants to merge 1 commit into from

Conversation

@Eijebong
Copy link
Member

Eijebong commented Oct 27, 2017 •
edited by SimonSapin

This change is Reviewable
@Eijebong
Bump bindgen to 0.31
Loading status checks…
97a4140
@highfive
Copy link

highfive commented Oct 27, 2017

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Oct 27, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@SimonSapin
SimonSapin reviewed Oct 28, 2017
View changes
Cargo.lock
@@ -3309,48 +3279,6 @@ dependencies = [
]

[[package]]
name = "syntex"

This comment has been minimized.

Sign in to view
@SimonSapin

SimonSapin Oct 28, 2017

Member

🎉🎉🎉
@SimonSapin
Copy link
Member

SimonSapin commented Oct 28, 2017

r=me if Firefox builds with this change
@emilio
Copy link
Member

emilio commented Oct 28, 2017

I suspect it does not, but testing now to see
@Eijebong
Copy link
Member Author

Eijebong commented Oct 28, 2017 •
edited

Currently blocked by:
@emilio
Copy link
Member

emilio commented Oct 30, 2017

https://bugzilla.mozilla.org/show_bug.cgi?id=1412486 Has all the necessary changes for this to be feasible.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2017

☔ The latest upstream changes (presumably #18967) made this pull request unmergeable. Please resolve the merge conflicts.
@Eijebong
Copy link
Member Author

Eijebong commented Oct 31, 2017

Closing in favour of #19072
@Eijebong Eijebong closed this Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonSapin SimonSapin

Assignees

@wafflespeanut wafflespeanut

Labels
S-awaiting-review S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Eijebong @highfive @SimonSapin @emilio @bors-servo @wafflespeanut
You can’t perform that action at this time.