Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CSS tests. #19070

Merged
merged 11 commits into from Nov 2, 2017
Merged

Enable CSS tests. #19070

merged 11 commits into from Nov 2, 2017

Conversation

@jdm
Copy link
Member

jdm commented Oct 31, 2017 •
edited by SimonSapin

Do not merge this; I'm looking into what it takes to stop running the test-css jobs.

This change is Reviewable
@jdm
Enable CSS tests.
Loading status checks…
a45031f
@highfive
Copy link

highfive commented Oct 31, 2017

Heads up! This PR modifies the following files:
@jdm
Copy link
Member Author

jdm commented Oct 31, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2017

⌛ Trying commit a45031f with merge a7eafec...
bors-servo added a commit that referenced this pull request Oct 31, 2017
@bors-servo
Auto merge of #19070 - jdm:csstests, r=<try>
Loading status checks…
a7eafec 
Enable CSS tests.

Do not merge this; I'm looking into what it takes to stop running the test-css jobs.
@jdm jdm changed the title Enable CSS tests. [DO NOT MERGE] Enable CSS tests. Oct 31, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2017

💔 Test failed - mac-rel-wpt3
@jdm
Duplicate existing CSS test metadata for newer testsuite.
Loading status checks…
15db457
@jdm
Copy link
Member Author

jdm commented Oct 31, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2017

⌛ Trying commit 15db457 with merge 73b2ef0...
bors-servo added a commit that referenced this pull request Oct 31, 2017
@bors-servo
Auto merge of #19070 - jdm:csstests, r=<try>
Loading status checks…
73b2ef0 
[DO NOT MERGE] Enable CSS tests.

Do not merge this; I'm looking into what it takes to stop running the test-css jobs.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19070)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2017

💔 Test failed - mac-rel-wpt3
@jdm
Copy link
Member Author

jdm commented Oct 31, 2017

@bors-servo: try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2017

⌛ Trying commit b260c4c with merge 86da19f...
bors-servo added a commit that referenced this pull request Oct 31, 2017
@bors-servo
Auto merge of #19070 - jdm:csstests, r=<try>
Loading status checks…
86da19f 
[DO NOT MERGE] Enable CSS tests.

Do not merge this; I'm looking into what it takes to stop running the test-css jobs.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19070)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2017

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member Author

jdm commented Nov 1, 2017

@bors-servo: try
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2017

⌛ Trying commit 203097a with merge 9452f54...
bors-servo added a commit that referenced this pull request Nov 1, 2017
@bors-servo
Auto merge of #19070 - jdm:csstests, r=<try>
Loading status checks…
9452f54 
[DO NOT MERGE] Enable CSS tests.

Do not merge this; I'm looking into what it takes to stop running the test-css jobs.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19070)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2017

💔 Test failed - mac-rel-wpt1
@jdm
Copy link
Member Author

jdm commented Nov 1, 2017 •
edited

Test job times:

  • servo-linux5 (linux-rel-wpt) before: ~18m
  • servo-linux5 (linux-rel-wpt) after: ~25.5
  • servo-mac4 (mac-rel-wpt1) before: ~23.5m
  • servo-mac5 (mac-rel-wpt1) after: ~28m
  • servo-mac5 (mac-rel-wpt2) before: ~11.5m
  • servo-mac9 (mac-rel-wpt2) after: ~22.5m
  • servo-mac7 (mac-rel-wpt3) before: ~21.5m
  • servo-mac7 (mac-rel-wpt3) after: ~30.5m
  • servo-mac1 (mac-rel-wpt4) before: ~14m
  • servo-mac1 (mac-rel-wpt4) after: ~18m

We could repurpose mac-rel-css1 and mac-rel-css2 to be mac-rel-wpt5 and mac-rel-wpt6 instead, and that should spread out the load quite a bit.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2017

💔 Test failed - mac-rel-wpt3
jdm added 4 commits Oct 31, 2017
@jdm
Update expected test results.
8d182cb
@jdm
Remove old webgl test expectations.
bf6d338
@jdm
Disable multicol tests.
1b4bc29
@jdm
Use mach logging for single XHTML tests.
557e2d6
@jdm jdm force-pushed the jdm:csstests branch from 03d9cab to 4397de3 Nov 1, 2017
@highfive highfive removed the S-tests-failed label Nov 1, 2017
@jdm jdm changed the title [DO NOT MERGE] Enable CSS tests. Enable CSS tests. Nov 1, 2017
This was referenced Nov 2, 2017
Merged
Closed
@jdm jdm force-pushed the jdm:csstests branch from 4397de3 to 041b4fd Nov 2, 2017
jdm added 5 commits Nov 1, 2017
@jdm
Update xml5ever to get better XHTML test results.
b225b2b
@jdm
Account for changes to Cargo.lock format.
b8e44e1
@jdm
Divide up CI jobs more evenly.
0094091
@jdm
Remove all outdated CSS tests.
12d22f6
@jdm
Remove all outdated CSS-related mach commands.
Loading status checks…
28c2098
@jdm jdm force-pushed the jdm:csstests branch from 041b4fd to 28c2098 Nov 2, 2017
@jdm
Copy link
Member Author

jdm commented Nov 2, 2017

@metajack This is now ready for review.
@metajack
Copy link
Contributor

metajack commented Nov 2, 2017

@bors-servo r+

For a delta of +30k and -7M this was surprisingly easy to review. Also, the new setup seems much simpler. Great work!
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2017

📌 Commit 28c2098 has been approved by metajack
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2017

⌛ Testing commit 28c2098 with merge 86b9e7d...
bors-servo added a commit that referenced this pull request Nov 2, 2017
@bors-servo
Auto merge of #19070 - jdm:csstests, r=metajack
Loading status checks…
86b9e7d 
Enable CSS tests.

Do not merge this; I'm looking into what it takes to stop running the test-css jobs.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19070)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: metajack
Pushing 86b9e7d to master...
@bors-servo bors-servo merged commit 28c2098 into servo:master Nov 2, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@jdm @highfive @bors-servo @metajack
You can’t perform that action at this time.