Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Update bindgen to 0.31.2. #19072

Merged
merged 4 commits into from Oct 31, 2017
Merged

style: Update bindgen to 0.31.2. #19072

merged 4 commits into from Oct 31, 2017

Conversation

@emilio
Copy link
Member

emilio commented Oct 31, 2017 •
edited by SimonSapin

Just waiting for a try run.

This change is Reviewable
emilio added 2 commits Oct 30, 2017
@emilio
style: Don't force ComputedValues to derive Debug.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
480d226 
The code that uses it is of dubious utility, fwiw, but some of it is used on
Servo, so I'll kill that separately.

Bug: 1412486
Reviewed-by: xidorn
MozReview-Commit-ID: KauvXX32zLM
@emilio
style: Unconditionally implement Debug for RefPtr.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
b5f8edc 
Bindgen doesn't know how to derive debug for a Gecko font family list. Hopefully
it doesn't need to.

Bug: 1412486
Reviewed-by: xidorn
MozReview-Commit-ID: 4iZKzjad6K9
@highfive
Copy link

highfive commented Oct 31, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/properties/gecko.mako.rs, components/style/build_gecko.rs, components/style/gecko/generated/bindings.rs, components/style/dom.rs and 3 more
  • @canaltinova: components/style/Cargo.toml, components/style/properties/gecko.mako.rs, components/style/build_gecko.rs, components/style/gecko/generated/bindings.rs, components/style/dom.rs and 3 more
@highfive
Copy link

highfive commented Oct 31, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Eijebong Eijebong mentioned this pull request Oct 31, 2017
Closed
@emilio
Copy link
Member Author

emilio commented Oct 31, 2017

I'm hitting rust-lang/rust-bindgen#1127 on older versions of llvm... Hopefully there was a testcase there already and I've been able to repro and debug :)
emilio added 2 commits Oct 30, 2017
@emilio
style: Update bindgen to 0.31.3.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
b721215 
Constified enums are default now. I think I want to introduce an option to
bindgen to allow setting the default enum behavior, but it doesn't need to block
this.

The ServoBindings.toml changes are somewhat hacky, but that's because of
rust-lang/rust-bindgen#1125.

Also, the fixups now need to account for whitespace, since quote generates stuff
like root :: nsString, and we don't rustfmt the bindings if there's no rustfmt
installed.

Bug: 1412486
Reviewed-by: xidorn
MozReview-Commit-ID: EY5eNnCiTIw
@emilio
style: Update bindings.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
4e6af72
@emilio emilio force-pushed the emilio:bindgen-up-finally branch from 6bcdbea to 4e6af72 Oct 31, 2017
@emilio
Copy link
Member Author

emilio commented Oct 31, 2017

Ok, new bindgen version, and I verified it builds and pass tests in central, yay!

@bors-servo r=xidorn
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2017

📌 Commit 4e6af72 has been approved by xidorn
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2017

⌛ Testing commit 4e6af72 with merge a376382...
@emilio
Copy link
Member Author

emilio commented Oct 31, 2017

@bors-servo p=10
bors-servo added a commit that referenced this pull request Oct 31, 2017
@bors-servo
Auto merge of #19072 - emilio:bindgen-up-finally, r=xidorn
Loading status checks…
a376382 
style: Update bindgen to 0.31.2.

Just waiting for a try run.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19072)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: xidorn
Pushing a376382 to master...
@bors-servo bors-servo merged commit 4e6af72 into servo:master Oct 31, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@emilio @highfive @bors-servo @pcwalton
You can’t perform that action at this time.