Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRename js crate to mozjs #19138
Merged
Rename js crate to mozjs #19138
Conversation
highfive
commented
Nov 7, 2017
highfive
commented
Nov 7, 2017
|
|
|
r? @jdm |
|
cc @fitzgen |
|
@bors-servo r=jdm |
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 8, 2017
…s, r=jdm Rename js crate to mozjs <!-- Please describe your changes on the following line: --> This PR renames the `js` dependency to `mozjs', ready for when servo/rust-mozjs#377 lands. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because refactoring <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19138) <!-- Reviewable:end -->
|
|
asajeffrey
force-pushed the
asajeffrey:script-rename-js-dependency-to-mozjs
branch
from
7dfb6b4
to
8008ba5
|
Sigh, forgot to check in the |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 8, 2017
…s, r=jdm Rename js crate to mozjs <!-- Please describe your changes on the following line: --> This PR renames the `js` dependency to `mozjs', ready for when servo/rust-mozjs#377 lands. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because refactoring <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19138) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedNov 7, 2017
•
edited by SimonSapin
This PR renames the
jsdependency to `mozjs', ready for when servo/rust-mozjs#377 lands../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is