Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable debug assertions for SpiderMonkey in CI #19150
Closed
+11
−11
Conversation
highfive
commented
Nov 8, 2017
|
Heads up! This PR modifies the following files:
|
|
@bors-servo: try |
bors-servo
added a commit
that referenced
this pull request
Nov 8, 2017
Enable debug assertions for SpiderMonkey in CI This should catch more instances of API misuse.
|
|
|
r=me, if it passes |
|
So many timeouts. This is not an improvement, unfortunately :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedNov 8, 2017
•
edited by SimonSapin
This should catch more instances of API misuse.
This change is