Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (hit test fix, render target pool optimizations, picture tree) #19236

Merged
merged 1 commit into from Nov 16, 2017
Merged

Update WR (hit test fix, render target pool optimizations, picture tree) #19236

merged 1 commit into from Nov 16, 2017

Conversation

@glennw
Copy link
Member

glennw commented Nov 15, 2017 •
edited by SimonSapin

This change is Reviewable
@jdm
Copy link
Member

jdm commented Nov 15, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2017

📌 Commit 912e66d has been approved by jdm
@highfive highfive assigned jdm and unassigned nox Nov 15, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2017

⌛ Testing commit 912e66d with merge 3739624...
bors-servo added a commit that referenced this pull request Nov 16, 2017
@bors-servo
Auto merge of #19236 - glennw:update-wr-pic, r=jdm
Loading status checks…
3739624 
Update WR (hit test fix, render target pool optimizations, picture tree)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19236)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2017

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Nov 16, 2017 

  ▶ FAIL [expected PASS] /css/compositing/mix-blend-mode/mix-blend-mode-animation.html
  └   → /css/compositing/mix-blend-mode/mix-blend-mode-animation.html 5514e28909e55e8bb7581416eb560b78f9592eee
/css/compositing/mix-blend-mode/reference/mix-blend-mode-animation-ref.html 0b76076b41713d8c3650a45c94c931b9a97367ef
Testing 5514e28909e55e8bb7581416eb560b78f9592eee == 0b76076b41713d8c3650a45c94c931b9a97367ef
@gw3583
Update WR (hit test fix, render target pool optimizations, picture tree)
Loading status checks…
b5df1c1
@glennw glennw force-pushed the glennw:update-wr-pic branch from 912e66d to b5df1c1 Nov 16, 2017
@glennw
Copy link
Member Author

glennw commented Nov 16, 2017

@jdm That test was previously accidentally passing. The reason it's failing now should be fixed by a PR in the WR queue (servo/webrender#2048). I'd like to land this in the interim though, since it fixes a hit testing issue. We should be able to re-enable that test next week.
@jdm
Copy link
Member

jdm commented Nov 16, 2017

Fine by me!
@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2017

📌 Commit b5df1c1 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2017

⌛ Testing commit b5df1c1 with merge fa61bfb...
bors-servo added a commit that referenced this pull request Nov 16, 2017
@bors-servo
Auto merge of #19236 - glennw:update-wr-pic, r=jdm
Loading status checks…
fa61bfb 
Update WR (hit test fix, render target pool optimizations, picture tree)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19236)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing fa61bfb to master...
@bors-servo bors-servo mentioned this pull request Nov 16, 2017
Open
2 of 5 tasks complete
@bors-servo bors-servo merged commit b5df1c1 into servo:master Nov 16, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@glennw @jdm @bors-servo @nox @highfive @gw3583
You can’t perform that action at this time.