Fetch cancellation #19274

Manishearth · 2017-11-17T23:07:40Z

This PR implements cancellation for fetch, and uses it for XHR. This means that fetch clients can now send a message to the fetch task asking for the network request to be aborted.

Previously, clients like XHR had abort functionality but would implement it by simply ignoring future messages from the network task; and would not actually cancel the network fetch.

This change is

highfive · 2017-11-17T23:07:44Z

Heads up! This PR modifies the following files:

@asajeffrey: components/constellation/network_listener.rs
@cbrewster: components/constellation/network_listener.rs
@paulrouget: components/constellation/network_listener.rs
@fitzgen: components/script/dom/xmlhttprequest.rs, components/script/document_loader.rs, components/script/dom/eventsource.rs, components/script/fetch.rs
@KiChjang: components/net/fetch/methods.rs, components/net/resource_thread.rs, components/net/http_loader.rs, components/script/dom/xmlhttprequest.rs, components/net_traits/lib.rs and 4 more

highfive · 2017-11-17T23:07:45Z

Warning

These commits modify net and script code, but no tests are modified. Please consider adding a test!

Manishearth · 2017-11-17T23:10:22Z

r? @jdm

Manishearth · 2017-11-17T23:10:28Z

Still need to test this

Manishearth · 2017-11-17T23:55:09Z

Tested manually, it works.

Testing methodology: Listen with nc -l port, have page set up XHR to listener with a button that aborts it, send back an HTTP response with content-length: largenumber, keep typing really long lines as responses (need to exceed the default chunking of hyper, I was sending responses that were just 10k "a"s). XHR should accept these responses just fine, but on calling abort the next chunk sent over should terminate netcat by closing the connection.


        Fetch cancellation: Add cancel_chan to FetchContext


        Fetch cancellation: Store cancel_chan in XHR


        Fetch cancellation: Send cancellation message whenever XHR needs to a…

…bort a fetch

gterzian · 2017-11-18T04:54:49Z

components/net/http_loader.rs

@@ -1109,6 +1110,11 @@ fn http_network_fetch(request: &Request,
                }

                loop {
+                    if cancellation_listener.lock().unwrap().cancelled() {
+                        *res_body.lock().unwrap() = ResponseBody::Done(vec![]);


In the context of #18676 I think that at this point the response would have been cached already, and such a cancellation would result in any subsequent request for the same url getting the empty cancelled response from the cache.

One way to solve this would be for the cache to disregard any cached responses that would have been cancelled. Checking for an empty response body might be one way to do so, perhaps a clearer way would be to use ResponseBody::Empty here instead, or even introduce a new ResponseBody::Cancelled?

Having had a look at the spec, the following can be considered:

At step 5 above, if at that point the fetch has already been aborted/terminated, you could return a network error.

If the fetch is terminated/aborted while the fetch worker is already performing step 12, in addition to what is done here and instead of what I suggested earlier, you could set a new aborted flag on the response. The cache could then also ignore any such aborted responses that would be held in it, when asked to construct a response. The spec mentions such a flag, see https://fetch.spec.whatwg.org/#concept-response-aborted, and it doesn't look like it has been implemented yet.

Let's add the flag to the response and set that here, and use the network error for prior to this point like gterzian suggested.

Manishearth · 2017-11-18T08:31:01Z

@bors-servo try

bors-servo · 2017-11-18T08:31:05Z

⌛ Trying commit 5b2b68d with merge a82585d...


        Auto merge of #19274 - Manishearth:xhr-cancel, r=<try>

Fetch cancellation This PR implements cancellation for fetch, and uses it for XHR. This means that fetch clients can now send a message to the fetch task asking for the network request to be aborted. Previously, clients like XHR had abort functionality but would implement it by simply ignoring future messages from the network task; and would not actually cancel the network fetch.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19274)

bors-servo · 2017-11-18T09:32:13Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True

jdm

Nice and readable!

jdm · 2017-11-20T23:30:21Z

components/net/fetch/methods.rs

+        if let Some(ref cancel_chan) = self.cancel_chan {
+            if self.cancelled {
+                true
+            } else if let Ok(_) = cancel_chan.try_recv() {


jdm · 2017-11-20T23:30:21Z

components/net/http_loader.rs

@@ -1109,6 +1110,11 @@ fn http_network_fetch(request: &Request,
                }

                loop {
+                    if cancellation_listener.lock().unwrap().cancelled() {
+                        *res_body.lock().unwrap() = ResponseBody::Done(vec![]);


Let's add the flag to the response and set that here, and use the network error for prior to this point like gterzian suggested.


        Fetch cancellation: Add CancellationListener


        Fetch cancellation: Listen for cancellation and prematurely abort if …

…cancelled


        Add aborted flag to response, set when fetch is aborted

Manishearth · 2017-11-21T01:05:18Z

Updated. Nit fixed and rolled into previous commit, added new commit for aborted flag.

jdm · 2017-11-21T01:21:03Z

@bors-servo: r+

bors-servo · 2017-11-21T01:21:04Z

📌 Commit 6f59b15 has been approved by jdm

bors-servo · 2017-11-21T02:48:19Z

⌛ Testing commit 6f59b15 with merge 00b3612...


        Auto merge of #19274 - Manishearth:xhr-cancel, r=jdm

Fetch cancellation This PR implements cancellation for fetch, and uses it for XHR. This means that fetch clients can now send a message to the fetch task asking for the network request to be aborted. Previously, clients like XHR had abort functionality but would implement it by simply ignoring future messages from the network task; and would not actually cancel the network fetch.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19274)

bors-servo · 2017-11-21T04:04:32Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 00b3612 to master...


        Auto merge of #19350 - gterzian:ignore_aborted_responses_in_caching, …

@jdm

…r=<try> Ignore aborted responses in caching  @jdm @KiChjang @Manishearth Follow up on #18676 and #19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19350)


        Auto merge of #19350 - gterzian:ignore_aborted_responses_in_caching, …

@jdm

…r=<try> Ignore aborted responses in caching  @jdm @KiChjang @Manishearth Follow up on #18676 and #19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19350)


        Auto merge of #19350 - gterzian:ignore_aborted_responses_in_caching, …

@jdm

…r=<try> Ignore aborted responses in caching  @jdm @KiChjang @Manishearth Follow up on #18676 and #19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19350)


        Auto merge of #19350 - gterzian:ignore_aborted_responses_in_caching, …

@jdm

…r=<try> Ignore aborted responses in caching  @jdm @KiChjang @Manishearth Follow up on #18676 and #19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19350)


        Auto merge of #19350 - gterzian:ignore_aborted_responses_in_caching, …

@jdm

…r=<try> Ignore aborted responses in caching  @jdm @KiChjang @Manishearth Follow up on #18676 and #19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19350)


        Auto merge of #19350 - gterzian:ignore_aborted_responses_in_caching, …

@jdm

…r=<try> Ignore aborted responses in caching  @jdm @KiChjang @Manishearth Follow up on #18676 and #19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19350)


        Auto merge of #19350 - gterzian:ignore_aborted_responses_in_caching, …

@jdm

…r=jdm Ignore aborted responses in caching  @jdm @KiChjang @Manishearth Follow up on #18676 and #19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19350)


        Auto merge of #19350 - gterzian:ignore_aborted_responses_in_caching, …

@jdm

…r=jdm Ignore aborted responses in caching  @jdm @KiChjang @Manishearth Follow up on #18676 and #19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19350)


        Auto merge of #19350 - gterzian:ignore_aborted_responses_in_caching, …

@jdm

…r=jdm Ignore aborted responses in caching  @jdm @KiChjang @Manishearth Follow up on #18676 and #19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19350)


        servo: Merge #19350 - Ignore aborted responses in caching (from gterz…

@jdm

…ian:ignore_aborted_responses_in_caching); r=jdm  @jdm @KiChjang @Manishearth Follow up on servo/servo#18676 and servo/servo#19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   Source-Repo: https://github.com/servo/servo Source-Revision: 4307b6e67b0cb35e2afc46ba0b64e7bc5bde1bdf --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 4631dd57c5f691119b287f2aa04ee97fedfdf406


        servo: Merge #19350 - Ignore aborted responses in caching (from gterz…

…ian:ignore_aborted_responses_in_caching); r=jdm  jdm KiChjang Manishearth Follow up on servo/servo#18676 and servo/servo#19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   Source-Repo: https://github.com/servo/servo Source-Revision: 4307b6e67b0cb35e2afc46ba0b64e7bc5bde1bdf UltraBlame original commit: e11d6ca7abe7416d5cead0c104b77a9b106f6363


        servo: Merge #19350 - Ignore aborted responses in caching (from gterz…

…ian:ignore_aborted_responses_in_caching); r=jdm  jdm KiChjang Manishearth Follow up on servo/servo#18676 and servo/servo#19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   Source-Repo: https://github.com/servo/servo Source-Revision: 4307b6e67b0cb35e2afc46ba0b64e7bc5bde1bdf UltraBlame original commit: e11d6ca7abe7416d5cead0c104b77a9b106f6363


        servo: Merge #19350 - Ignore aborted responses in caching (from gterz…

…ian:ignore_aborted_responses_in_caching); r=jdm  jdm KiChjang Manishearth Follow up on servo/servo#18676 and servo/servo#19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   Source-Repo: https://github.com/servo/servo Source-Revision: 4307b6e67b0cb35e2afc46ba0b64e7bc5bde1bdf UltraBlame original commit: e11d6ca7abe7416d5cead0c104b77a9b106f6363

highfive assigned emilio Nov 17, 2017

highfive added the S-awaiting-review label Nov 17, 2017

Manishearth force-pushed the Manishearth:xhr-cancel branch from ef7088a to d82315a Nov 17, 2017

highfive assigned jdm and unassigned emilio Nov 17, 2017

Manishearth added 3 commits Nov 17, 2017

Fetch cancellation: Add cancel_chan to FetchContext

1dfb125

Fetch cancellation: Store cancel_chan in XHR

87e4c15

Fetch cancellation: Send cancellation message whenever XHR needs to a…

27457e4

…bort a fetch

gterzian reviewed Nov 18, 2017

View changes

Manishearth force-pushed the Manishearth:xhr-cancel branch from d82315a to 5b2b68d Nov 18, 2017

jdm requested changes Nov 20, 2017

View changes

jdm added S-needs-code-changes and removed S-awaiting-review labels Nov 20, 2017

Manishearth added 2 commits Nov 17, 2017

Fetch cancellation: Add CancellationListener

6dd7af2

Fetch cancellation: Listen for cancellation and prematurely abort if …

7249fd6

…cancelled

Manishearth force-pushed the Manishearth:xhr-cancel branch from 5b2b68d to 14115ce Nov 21, 2017

highfive added S-awaiting-review and removed S-needs-code-changes labels Nov 21, 2017

Add aborted flag to response, set when fetch is aborted

Loading status checks…

6f59b15

Manishearth force-pushed the Manishearth:xhr-cancel branch from 14115ce to 6f59b15 Nov 21, 2017

jdm mentioned this pull request Nov 21, 2017

Implement document load cancellation #19309

Closed

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 21, 2017

bors-servo merged commit 6f59b15 into servo:master Nov 21, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Nov 21, 2017

jdm mentioned this pull request Nov 21, 2017

Implement fetch abortion #18671

Closed

gterzian mentioned this pull request Nov 23, 2017

Ignore aborted responses in caching #19350

Merged

0 of 5 tasks complete

Manishearth deleted the Manishearth:xhr-cancel branch Jul 11, 2019

servo / servo

Fetch cancellation #19274

Fetch cancellation #19274

Manishearth commented Nov 17, 2017 •

edited by SimonSapin

highfive commented Nov 17, 2017

highfive commented Nov 17, 2017

Manishearth commented Nov 17, 2017

Manishearth commented Nov 17, 2017

Manishearth commented Nov 17, 2017

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Manishearth commented Nov 18, 2017

bors-servo commented Nov 18, 2017

bors-servo commented Nov 18, 2017

jdm left a comment

This comment has been minimized.

This comment has been minimized.

Manishearth commented Nov 21, 2017

jdm commented Nov 21, 2017

bors-servo commented Nov 21, 2017

bors-servo commented Nov 21, 2017

bors-servo commented Nov 21, 2017

servo / servo

Join GitHub today

Fetch cancellation #19274

Fetch cancellation #19274

Conversation

Manishearth commented Nov 17, 2017 • edited by SimonSapin

highfive commented Nov 17, 2017

highfive commented Nov 17, 2017

Manishearth commented Nov 17, 2017

Manishearth commented Nov 17, 2017

Manishearth commented Nov 17, 2017

This comment has been minimized.

gterzian Nov 18, 2017

This comment has been minimized.

gterzian Nov 18, 2017 • edited

This comment has been minimized.

jdm Nov 20, 2017

Manishearth commented Nov 18, 2017

bors-servo commented Nov 18, 2017

bors-servo commented Nov 18, 2017

jdm left a comment

This comment has been minimized.

jdm Nov 20, 2017

This comment has been minimized.

jdm Nov 20, 2017

Manishearth commented Nov 21, 2017

jdm commented Nov 21, 2017

bors-servo commented Nov 21, 2017

bors-servo commented Nov 21, 2017

bors-servo commented Nov 21, 2017

Manishearth commented Nov 17, 2017 •

edited by SimonSapin

gterzian Nov 18, 2017 •

edited