Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving :dir() param serialization FIXME #19332

Merged
merged 1 commit into from Nov 22, 2017
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

moving :dir() param serialization FIXME

  • Loading branch information
wilsoniya committed Nov 22, 2017
commit 1ebc1382ce44af71f7758b061d94a9b6a4f4f0e9
@@ -96,7 +96,6 @@ impl ToCss for NonTSPseudoClass {
}, )*
NonTSPseudoClass::Dir(ref dir) => {
dest.write_str(":dir(")?;
// FIXME: This should be escaped as an identifier; see #19231
(**dir).to_css(dest)?;
return dest.write_char(')')
},
@@ -191,6 +191,7 @@ impl ToCss for Direction {
let dir_str = match *self {
Direction::Rtl => "rtl",
Direction::Ltr => "ltr",
// FIXME: This should be escaped as an identifier; see #19231
Direction::Other(ref other) => other,
};
dest.write_str(dir_str)
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.