Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme for ubuntu build #19356

Merged
merged 1 commit into from Nov 23, 2017
Merged

update readme for ubuntu build #19356

merged 1 commit into from Nov 23, 2017

Conversation

@tigercosmos
Copy link
Collaborator

tigercosmos commented Nov 23, 2017

Fix Ubuntu build


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #19351 (github issue number if applicable).

This change is Reviewable

@jdm
Copy link
Member

jdm commented Nov 23, 2017

#19353 does not add clang packages for ubuntu.

@tigercosmos
Copy link
Collaborator Author

tigercosmos commented Nov 23, 2017

Ops.. Sorry!

@tigercosmos
Copy link
Collaborator Author

tigercosmos commented Nov 23, 2017

It would be OK now

@jdm
Copy link
Member

jdm commented Nov 23, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2017

📌 Commit 4e8a96c has been approved by jdm

@highfive highfive assigned jdm and unassigned nox Nov 23, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2017

Testing commit 4e8a96c with merge 6009441...

bors-servo added a commit that referenced this pull request Nov 23, 2017
update readme for ubuntu build

<!-- Please describe your changes on the following line: -->

Fix Ubuntu build

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix  #19351 (github issue number if applicable).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19356)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2017

@bors-servo bors-servo merged commit 4e8a96c into servo:master Nov 23, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@tigercosmos tigercosmos deleted the tigercosmos:r1 branch Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.