Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't confuse Cargo when building dependencies. #19413
Merged
Conversation
|
@bors-servo r+ this works magically. nice work @jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 29, 2017
Don't confuse Cargo when building dependencies. It's not totally clear why this is experienced intermittently (see #19402), but this allowed mp4parse-capi to actually build on my machine. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19413) <!-- Reviewable:end -->
|
This hack should be documented and removed as soon as we understand why it does the trick and we find the proper fix. |
This was referenced Nov 29, 2017
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedNov 28, 2017
•
edited by SimonSapin
It's not totally clear why this is experienced intermittently (see #19402), but this allowed mp4parse-capi to actually build on my machine.
This change is