Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (AA on transformed box-shadows, resource leak fixes) #19414

Merged
merged 1 commit into from Dec 7, 2017
Merged

Update WR (AA on transformed box-shadows, resource leak fixes) #19414

merged 1 commit into from Dec 7, 2017

Conversation

@glennw
Copy link
Member

glennw commented Nov 28, 2017 •
edited by SimonSapin

This change is Reviewable
@glennw
Copy link
Member Author

glennw commented Nov 28, 2017

r? anyone
@KiChjang
Copy link
Member

KiChjang commented Nov 28, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2017

📌 Commit 6a8be1b has been approved by KiChjang
@highfive highfive assigned KiChjang and unassigned wafflespeanut Nov 28, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2017

⌛ Testing commit 6a8be1b with merge 3e6458a...
bors-servo added a commit that referenced this pull request Nov 28, 2017
@bors-servo
Auto merge of #19414 - glennw:update-wr-leaks, r=KiChjang
Loading status checks…
3e6458a 
Update WR (AA on transformed box-shadows, resource leak fixes)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19414)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2017

💔 Test failed - linux-rel-css
@KiChjang
Copy link
Member

KiChjang commented Nov 28, 2017 

  ▶ FAIL [expected PASS] /css/compositing/mix-blend-mode/mix-blend-mode-intermediate-element-overflow-hidden-and-border-radius.html
  └   → /css/compositing/mix-blend-mode/mix-blend-mode-intermediate-element-overflow-hidden-and-border-radius.html 49ccc05739443927d8e1bf333d2191d978c0a4c4
/css/compositing/mix-blend-mode/reference/mix-blend-mode-intermediate-element-overflow-hidden-and-border-radius-ref.html 403d6ed3567e2736f5445c3eb43353f2cde7c66d
Testing 49ccc05739443927d8e1bf333d2191d978c0a4c4 == 403d6ed3567e2736f5445c3eb43353f2cde7c66d
@glennw
Copy link
Member Author

glennw commented Dec 1, 2017

This has a small number of pixel differences. It looks like an anti-aliasing issue. There's a couple of PRs coming in WR today that might fix this. If it's not fixed by those, I'll take a more detailed look.
@glennw glennw force-pushed the glennw:update-wr-leaks branch from 6a8be1b to 8264ed6 Dec 4, 2017
@glennw
Copy link
Member Author

glennw commented Dec 4, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 4, 2017

⌛ Trying commit 8264ed6 with merge 30c4456...
bors-servo added a commit that referenced this pull request Dec 4, 2017
@bors-servo
Auto merge of #19414 - glennw:update-wr-leaks, r=<try>
Loading status checks…
30c4456 
Update WR (AA on transformed box-shadows, resource leak fixes)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19414)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 4, 2017

💔 Test failed - linux-rel-css
@glennw
Copy link
Member Author

glennw commented Dec 4, 2017

@bors-servo retry

  • infra
@bors-servo
Copy link
Contributor

bors-servo commented Dec 4, 2017

⌛ Trying commit 8264ed6 with merge d166942...
bors-servo added a commit that referenced this pull request Dec 4, 2017
@bors-servo
Auto merge of #19414 - glennw:update-wr-leaks, r=<try>
Loading status checks…
d166942 
Update WR (AA on transformed box-shadows, resource leak fixes)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19414)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 4, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True
@jdm
Copy link
Member

jdm commented Dec 4, 2017

This PR appears to only update byteorder now.
@glennw glennw force-pushed the glennw:update-wr-leaks branch from 8264ed6 to 1ee2e3c Dec 4, 2017
@glennw glennw force-pushed the glennw:update-wr-leaks branch from 6069af9 to 9c11369 Dec 7, 2017
@highfive highfive removed the S-tests-failed label Dec 7, 2017
@glennw
Copy link
Member Author

glennw commented Dec 7, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2017

⌛ Trying commit 9c11369 with merge 00f1146...
bors-servo added a commit that referenced this pull request Dec 7, 2017
@bors-servo
Auto merge of #19414 - glennw:update-wr-leaks, r=<try>
Loading status checks…
00f1146 
Update WR (AA on transformed box-shadows, resource leak fixes)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19414)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2017

💔 Test failed - mac-rel-wpt2
@gw3583
Update WR (AA improvements, many optimizations)
Loading status checks…
58473cf
@glennw glennw force-pushed the glennw:update-wr-leaks branch from 9c11369 to 58473cf Dec 7, 2017
@highfive highfive removed the S-tests-failed label Dec 7, 2017
@glennw
Copy link
Member Author

glennw commented Dec 7, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2017

⌛ Trying commit 58473cf with merge 4a7db8d...
bors-servo added a commit that referenced this pull request Dec 7, 2017
@bors-servo
Auto merge of #19414 - glennw:update-wr-leaks, r=<try>
Loading status checks…
4a7db8d 
Update WR (AA on transformed box-shadows, resource leak fixes)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19414)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True
@glennw
Copy link
Member Author

glennw commented Dec 7, 2017

r? anyone (the duplicate of smallvec should be resolved in the next WR update).
@wafflespeanut
Copy link
Member

wafflespeanut commented Dec 7, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2017

📌 Commit 58473cf has been approved by wafflespeanut
@highfive highfive assigned wafflespeanut and unassigned KiChjang Dec 7, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2017

⌛ Testing commit 58473cf with merge e646471...
bors-servo added a commit that referenced this pull request Dec 7, 2017
@bors-servo
Auto merge of #19414 - glennw:update-wr-leaks, r=wafflespeanut
Loading status checks…
e646471 
Update WR (AA on transformed box-shadows, resource leak fixes)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19414)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: wafflespeanut
Pushing e646471 to master...
@bors-servo bors-servo merged commit 58473cf into servo:master Dec 7, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@glennw glennw deleted the glennw:update-wr-leaks branch Dec 7, 2017
@bors-servo bors-servo mentioned this pull request Dec 7, 2017
Closed
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@glennw @KiChjang @bors-servo @jdm @wafflespeanut @highfive @gw3583
You can’t perform that action at this time.