Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unused generic from push_applicable_declarations #19424
Merged
+12
−22
Conversation
This function is only ever used with one type. This gets rid of the only use of the `smallvec::VecLike` trait, which we may want to deprecate. (If we do need to make this function generic in the future, we can do it using standard traits instead.)
highfive
commented
Nov 29, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Nov 29, 2017
|
|
|
@bors-servo r+ |
|
|
|
Thanks! |
bors-servo
added a commit
that referenced
this pull request
Nov 29, 2017
Remove unused generic from push_applicable_declarations This function is only ever used with one type. This gets rid of the only use of the `smallvec::VecLike` trait, which we may want to deprecate (servo/rust-smallvec#35). If we do need to make this function generic in the future, we can do it using standard traits instead. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they are removing unused code <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19424) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
to servo/rust-smallvec
that referenced
this pull request
Nov 29, 2017
Deprecate the VecLike trait This is an update of PR #35. This trait is redundant with existing traits like `Extend` and `Deref`. Its purpose is unclear (you can do a few things with it, but not much) and the one use case I know of has been removed (servo/servo#19424). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/74) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedNov 29, 2017
•
edited by SimonSapin
This function is only ever used with one type.
This gets rid of the only use of the
smallvec::VecLiketrait, which we may want to deprecate (servo/rust-smallvec#35). If we do need to make this function generic in the future, we can do it using standard traits instead../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is