Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add picture element #19431

Merged
merged 1 commit into from Jan 30, 2018
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -54,6 +54,7 @@ use dom::htmloptionelement::HTMLOptionElement;
use dom::htmloutputelement::HTMLOutputElement;
use dom::htmlparagraphelement::HTMLParagraphElement;
use dom::htmlparamelement::HTMLParamElement;
use dom::htmlpictureelement::HTMLPictureElement;
use dom::htmlpreelement::HTMLPreElement;
use dom::htmlprogresselement::HTMLProgressElement;
use dom::htmlquoteelement::HTMLQuoteElement;
@@ -309,6 +310,7 @@ pub fn create_native_html_element(
local_name!("output") => make!(HTMLOutputElement),
local_name!("p") => make!(HTMLParagraphElement),
local_name!("param") => make!(HTMLParamElement),
local_name!("picture") => make!(HTMLPictureElement),
local_name!("plaintext") => make!(HTMLPreElement),
local_name!("pre") => make!(HTMLPreElement),
local_name!("progress") => make!(HTMLProgressElement),
@@ -0,0 +1,36 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

use dom::bindings::codegen::Bindings::HTMLPictureElementBinding;
use dom::bindings::root::DomRoot;
use dom::document::Document;
use dom::htmlelement::HTMLElement;
use dom::node::Node;
use dom_struct::dom_struct;
use html5ever::{LocalName, Prefix};

#[dom_struct]
pub struct HTMLPictureElement {
htmlelement: HTMLElement,
}

impl HTMLPictureElement {
fn new_inherited(local_name: LocalName,
prefix: Option<Prefix>,
document: &Document) -> HTMLPictureElement {
HTMLPictureElement {
htmlelement:
HTMLElement::new_inherited(local_name, prefix, document)
}
}

#[allow(unrooted_must_root)]
pub fn new(local_name: LocalName,
prefix: Option<Prefix>,
document: &Document) -> DomRoot<HTMLPictureElement> {
Node::reflect_node(Box::new(HTMLPictureElement::new_inherited(local_name, prefix, document)),
document,
HTMLPictureElementBinding::Wrap)
}
}
@@ -348,6 +348,7 @@ pub mod htmloptionscollection;
pub mod htmloutputelement;
pub mod htmlparagraphelement;
pub mod htmlparamelement;
pub mod htmlpictureelement;
pub mod htmlpreelement;
pub mod htmlprogresselement;
pub mod htmlquoteelement;
@@ -0,0 +1,7 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

// https://html.spec.whatwg.org/multipage/#htmlpictureelement
[HTMLConstructor]
interface HTMLPictureElement : HTMLElement {};
@@ -2,3 +2,4 @@
type: testharness
[ ]
expected: FAIL

@@ -1,4 +1,5 @@
[css3-text-line-break-baspglwj-094.html]
type: testharness
[ ]
expected: FAIL
expected: FAIL

@@ -1200,24 +1200,6 @@
[HTMLModElement interface: document.createElement("del") must inherit property "dateTime" with the proper type (1)]
expected: FAIL

[HTMLPictureElement interface: existence and properties of interface object]
expected: FAIL

[HTMLPictureElement interface object length]
expected: FAIL

[HTMLPictureElement interface: existence and properties of interface prototype object]
expected: FAIL

[HTMLPictureElement interface: existence and properties of interface prototype object's "constructor" property]
expected: FAIL
[HTMLPictureElement must be primary interface of document.createElement("picture")]
expected: FAIL
[Stringification of document.createElement("picture")]
expected: FAIL
[HTMLImageElement interface: attribute srcset]
expected: FAIL

@@ -5832,9 +5814,6 @@
[DOMElementMap interface object name]
expected: FAIL
[HTMLPictureElement interface object name]
expected: FAIL

[AudioTrackList interface object name]
expected: FAIL
@@ -48,12 +48,6 @@
[Interfaces for MENUITEM]
expected: FAIL

[Interfaces for picture]
expected: FAIL

[Interfaces for PICTURE]
expected: FAIL

[Interfaces for slot]
expected: FAIL

"testharness"
],
"mozilla/interfaces.html": [
"ad914ab4c7a794b251c03f7b0f50aaef1ea78df0",
"365c76c771b3d79a671b04047923f5644efb9b93",
"testharness"
],
"mozilla/interfaces.js": [

This file was deleted.

@@ -114,6 +114,7 @@
"HTMLOutputElement",
"HTMLParagraphElement",
"HTMLParamElement",
"HTMLPictureElement",
"HTMLPreElement",
"HTMLProgressElement",
"HTMLQuoteElement",
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.