Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FFI functions for Gecko @counter-style value parsing #19441

Merged
merged 3 commits into from Dec 4, 2017

Conversation

Projects
None yet
7 participants
@heycam
Copy link
Member

commented Dec 1, 2017

Servo-side part of https://bugzilla.mozilla.org/show_bug.cgi?id=1420117, reviewed there by Xidorn.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Dec 1, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, components/style/counter_style/mod.rs, ports/geckolib/glue.rs, components/style/gecko/generated/structs.rs
  • @canaltinova: components/style/gecko/generated/bindings.rs, components/style/counter_style/mod.rs, components/style/gecko/generated/structs.rs
  • @emilio: components/style/gecko/generated/bindings.rs, components/style/counter_style/mod.rs, ports/geckolib/glue.rs, components/style/gecko/generated/structs.rs
@highfive

This comment has been minimized.

Copy link

commented Dec 1, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@heycam heycam changed the title Counter parse add FFI functions for Gecko @counter-style value parsing Dec 1, 2017

@heycam

This comment has been minimized.

Copy link
Member Author

commented Dec 1, 2017

@bors-servo r=upsuper

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2017

📌 Commit 8808cb4 has been approved by upsuper

@highfive highfive assigned upsuper and unassigned cbrewster Dec 1, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2017

⌛️ Testing commit 8808cb4 with merge 7aa117a...

bors-servo added a commit that referenced this pull request Dec 1, 2017

Auto merge of #19441 - heycam:counter-parse, r=upsuper
add FFI functions for Gecko @counter-style value parsing

Servo-side part of https://bugzilla.mozilla.org/show_bug.cgi?id=1420117, reviewed there by Xidorn.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19441)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2017

💔 Test failed - linux-rel-css

@jdm

This comment has been minimized.

Copy link
Member

commented Dec 1, 2017

@bors-servo: retry

  • I don't understand what went wrong, but it appears to be isolated to that single job?
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2017

💔 Test failed - linux-rel-css

@heycam

This comment has been minimized.

Copy link
Member Author

commented Dec 1, 2017

@bors-servo retry

  • Same timeouts. My patches here shouldn't affect Servo builds at all.
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2017

💔 Test failed - linux-rel-css

@jdm

This comment has been minimized.

Copy link
Member

commented Dec 1, 2017

I've pressed the "graceful shutdown" button on the linux3 build machine; hopefully we can cause a different machine to be selected when retrying next time.

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2017

☔️ The latest upstream changes (presumably #19436) made this pull request unmergeable. Please resolve the merge conflicts.

@heycam

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2017

🔒 Merge conflict

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2017

⌛️ Testing commit ec4f9a5 with merge 2326517...

bors-servo added a commit that referenced this pull request Dec 4, 2017

Auto merge of #19441 - heycam:counter-parse, r=upsuper
add FFI functions for Gecko @counter-style value parsing

Servo-side part of https://bugzilla.mozilla.org/show_bug.cgi?id=1420117, reviewed there by Xidorn.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19441)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2017

💔 Test failed - linux-rel-css

@heycam

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2017

@bors-servo retry

  • One more try for those timeouts. Otherwise I'm not sure what to do...
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2017

💔 Test failed - linux-rel-wpt

@heycam

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2017

💔 Test failed - linux-rel-css

@emilio

This comment has been minimized.

Copy link
Member

commented Dec 4, 2017

@bors-servo retry

  • Srsly
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2017

💔 Test failed - linux-rel-css

@jdm

This comment has been minimized.

Copy link
Member

commented Dec 4, 2017

@bors-servo: retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2017

⌛️ Testing commit ec4f9a5 with merge 221d72a...

bors-servo added a commit that referenced this pull request Dec 4, 2017

Auto merge of #19441 - heycam:counter-parse, r=upsuper
add FFI functions for Gecko @counter-style value parsing

Servo-side part of https://bugzilla.mozilla.org/show_bug.cgi?id=1420117, reviewed there by Xidorn.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19441)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2017

@bors-servo bors-servo merged commit ec4f9a5 into servo:master Dec 4, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

moz-servo-sync added a commit to moz-servo-sync/servo that referenced this pull request Dec 5, 2017

Backed out 1 changesets because the gecko part (bug 1420117) has to b…
…e backed out for the mochitests r=backout on a CLOSED TREE

Backed out changeset baada68cad47

Backs out servo#19441

bors-servo added a commit that referenced this pull request Dec 5, 2017

Auto merge of #19488 - moz-servo-sync:gecko-backout, r=moz-servo-sync
Backed out 1 changesets because the gecko part (bug 1420117) has to be backed out for the mochitests r=backout on a CLOSED TREE

Backed out 1 changesets because the gecko part (bug 1420117) has to be backed out for the mochitests r=backout on a CLOSED TREE

Backed out changeset baada68cad47

Backs out #19441

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19488)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request Dec 5, 2017

Auto merge of #19489 - heycam:counter-parse-2, r=upsuper
add FFI functions for Gecko @counter-style value parsing

Trying to land #19441 again.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19489)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.