Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Make -moz-border-colors chrome only. #19446

Merged
merged 1 commit into from Dec 1, 2017
Merged

style: Make -moz-border-colors chrome only. #19446

merged 1 commit into from Dec 1, 2017

Conversation

@emilio
Copy link
Member

emilio commented Dec 1, 2017 •
edited by SimonSapin

This also makes the border shorthand not reset them.

Bug: 1417200
Reviewed-by: xidorn
MozReview-Commit-ID: KNais1e5FnE

This change is Reviewable
@highfive
Copy link

highfive commented Dec 1, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/shorthand/border.mako.rs, components/style/properties/longhand/border.mako.rs
  • @canaltinova: components/style/properties/shorthand/border.mako.rs, components/style/properties/longhand/border.mako.rs
@highfive
Copy link

highfive commented Dec 1, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Dec 1, 2017

@bors-servo r=xidorn
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2017

📌 Commit e612622 has been approved by xidorn
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2017

⌛ Testing commit e612622 with merge 63986ca...
bors-servo added a commit that referenced this pull request Dec 1, 2017
@bors-servo
Auto merge of #19446 - emilio:bye-moz-border-colors, r=xidorn
Loading status checks…
63986ca 
style: Make -moz-border-colors chrome only.

This also makes the `border` shorthand not reset them.

Bug: 1417200
Reviewed-by: xidorn
MozReview-Commit-ID: KNais1e5FnE

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19446)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2017

💔 Test failed - mac-dev-unit
@emilio
Copy link
Member Author

emilio commented Dec 1, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2017

⚡ Previous build results for android are reusable. Rebuilding only arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2017

💔 Test failed - linux-dev
@jdm
Copy link
Member

jdm commented Dec 1, 2017 

	thread 'size_of::test_size_of_parsed_declaration' panicked at 'Your changes have decreased the stack size of style::properties::SourcePropertyDeclaration from 704 to 576. Good work! Please update the expected size in /home/servo/buildbot/slave/linux-dev/build/tests/unit/stylo/size_of.rs.', /home/servo/buildbot/slave/linux-dev/build/tests/unit/stylo/size_of.rs:53:0

Wow.
@emilio
Copy link
Member Author

emilio commented Dec 1, 2017

Neat :)
@emilio
style: Make -moz-border-colors chrome only.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
0f12380 
This also makes the `border` shorthand not reset them.

Bug: 1417200
Reviewed-by: xidorn
MozReview-Commit-ID: KNais1e5FnE
@emilio emilio force-pushed the emilio:bye-moz-border-colors branch from e612622 to 0f12380 Dec 1, 2017
@emilio
Copy link
Member Author

emilio commented Dec 1, 2017

@bors-servo r=xidorn p=1
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2017

📌 Commit 0f12380 has been approved by xidorn
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2017

⌛ Testing commit 0f12380 with merge af8d533...
bors-servo added a commit that referenced this pull request Dec 1, 2017
@bors-servo
Auto merge of #19446 - emilio:bye-moz-border-colors, r=xidorn
Loading status checks…
af8d533 
style: Make -moz-border-colors chrome only.

This also makes the `border` shorthand not reset them.

Bug: 1417200
Reviewed-by: xidorn
MozReview-Commit-ID: KNais1e5FnE

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19446)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: xidorn
Pushing af8d533 to master...
@bors-servo bors-servo merged commit 0f12380 into servo:master Dec 1, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the emilio:bye-moz-border-colors branch Dec 2, 2017
@emilio emilio mentioned this pull request Feb 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @bors-servo @jdm @pcwalton
You can’t perform that action at this time.