Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Update cssparser to 0.23. #19456

Closed
wants to merge 1 commit into from
Closed

style: Update cssparser to 0.23. #19456

wants to merge 1 commit into from
+26 −27

Conversation

@emilio
Copy link
Member

emilio commented Dec 1, 2017 •
edited by SimonSapin

Token::Column is no more! (servo/rust-cssparser#205)

This change is Reviewable
@emilio
style: Update cssparser to 0.23.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
5e9e121
@highfive
Copy link

highfive commented Dec 1, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/selectors/Cargo.toml, components/style/error_reporting.rs, ports/geckolib/Cargo.toml
  • @asajeffrey: components/script_layout_interface/Cargo.toml, components/script/Cargo.toml
  • @canaltinova: components/style/Cargo.toml, components/style/error_reporting.rs
  • @fitzgen: components/script_layout_interface/Cargo.toml, components/script/Cargo.toml
  • @KiChjang: components/script_layout_interface/Cargo.toml, components/script/Cargo.toml
@nox
Copy link
Member

nox commented Dec 1, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2017

📌 Commit 5e9e121 has been approved by nox
@emilio emilio mentioned this pull request Dec 1, 2017
Merged
bors-servo added a commit that referenced this pull request Dec 2, 2017
@bors-servo
Auto merge of #19457 - emilio:color-calc, r=<try>
Loading status checks…
3c61213 
style: support calc() in color functions.

Depends on #19456 and servo/rust-cssparser#207.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19457)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Dec 2, 2017
@bors-servo
Auto merge of #19457 - emilio:color-calc, r=<try>
Loading status checks…
82eeb01 
style: support calc() in color functions.

Depends on #19456 and servo/rust-cssparser#207.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19457)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 2, 2017

⌛ Testing commit 5e9e121 with merge 8da94f7...
bors-servo added a commit that referenced this pull request Dec 2, 2017
@bors-servo
Auto merge of #19456 - emilio:cssparserup_, r=nox
Loading status checks…
8da94f7 
style: Update cssparser to 0.23.

`Token::Column` is no more! (servo/rust-cssparser#205)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19456)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 2, 2017

💔 Test failed - linux-rel-css
@emilio
Copy link
Member Author

emilio commented Dec 2, 2017

@bors-servo retry

  • Tons of unrelated test passes and timeouts
@bors-servo
Copy link
Contributor

bors-servo commented Dec 2, 2017

⌛ Testing commit 5e9e121 with merge d6078e2...
bors-servo added a commit that referenced this pull request Dec 2, 2017
@bors-servo
Auto merge of #19456 - emilio:cssparserup_, r=nox
Loading status checks…
d6078e2 
style: Update cssparser to 0.23.

`Token::Column` is no more! (servo/rust-cssparser#205)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19456)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 2, 2017

💔 Test failed - linux-rel-css
@emilio
Copy link
Member Author

emilio commented Dec 2, 2017

@bors-servo retry

  • Still makes zarroo sense, since #19457 includes it and was green.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 2, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 2, 2017

💔 Test failed - linux-rel-css
@emilio
Copy link
Member Author

emilio commented Dec 2, 2017

Seriously, wtf is wrong with that builder...

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 2, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@emilio
Copy link
Member Author

emilio commented Dec 3, 2017

@bors-servo retry
bors-servo added a commit that referenced this pull request Dec 3, 2017
@bors-servo
Auto merge of #19456 - emilio:cssparserup_, r=nox
Loading status checks…
c459dcb 
style: Update cssparser to 0.23.

`Token::Column` is no more! (servo/rust-cssparser#205)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19456)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 3, 2017

⌛ Testing commit 5e9e121 with merge c459dcb...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 3, 2017

💔 Test failed - linux-rel-css
@emilio
Copy link
Member Author

emilio commented Dec 3, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 3, 2017

⌛ Testing commit 5e9e121 with merge d32af2b...
bors-servo added a commit that referenced this pull request Dec 3, 2017
@bors-servo
Auto merge of #19456 - emilio:cssparserup_, r=nox
Loading status checks…
d32af2b 
style: Update cssparser to 0.23.

`Token::Column` is no more! (servo/rust-cssparser#205)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19456)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 3, 2017

💔 Test failed - mac-dev-unit
@emilio
Copy link
Member Author

emilio commented Dec 3, 2017

@bors-servo retry

  • sccache
@bors-servo
Copy link
Contributor

bors-servo commented Dec 3, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt, mac-dev-unit...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 3, 2017

💔 Test failed - linux-rel-wpt
@emilio
Copy link
Member Author

emilio commented Dec 4, 2017

@bors-servo retry

  • srsly
@bors-servo
Copy link
Contributor

bors-servo commented Dec 4, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 4, 2017

💔 Test failed - linux-rel-css
@emilio
Copy link
Member Author

emilio commented Dec 4, 2017

Bleh, I'll just land it as part of #19457, but this is very unfortunate...
@emilio emilio closed this Dec 4, 2017
@emilio emilio deleted the emilio:cssparserup_ branch Dec 4, 2017
bors-servo added a commit that referenced this pull request Dec 5, 2017
@bors-servo
Auto merge of #19457 - emilio:color-calc, r=SimonSapin
Loading status checks…
5b9c595 
style: support calc() in color functions.

Depends on #19456 and servo/rust-cssparser#207.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=984021

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19457)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Dec 5, 2017
@bors-servo
Auto merge of #19457 - emilio:color-calc, r=SimonSapin
Loading status checks…
3cef09a 
style: support calc() in color functions.

Depends on #19456 and servo/rust-cssparser#207.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=984021

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19457)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@emilio @highfive @nox @bors-servo
You can’t perform that action at this time.