Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse workspace.default-members to specify default crates for cargo build #19476
Conversation
|
@bors-servo r+ |
|
|
|
@bors-servo r+ |
|
|
|
@bors-servo: treeclosed=9000 |
|
|
|
Rebased without conflict. (Maybe GitHub uses a different automatic conflict resolution algorithm than my git client?) @bors-servo r=nox |
|
|
Use workspace.default-members to specify default crates for cargo build … and 'cargo test', etc. Include Servo and its unit tests, but not Stylo because that would try to compile the style crate with incompatible feature flags: rust-lang/cargo#4463 `workspace.default-members` was added in rust-lang/cargo#4743. Older Cargo versions ignore it. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19476) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry
|
|
That means the rustc process terminated with a non-zero (unsuccessful) exit code. However there is no error message from rustc. Maybe rustc segfaulted? I can’t reproduce though :/ Let’s see if it happens reliably. @bors-servo retry (Note that this PR includes a compiler upgrade.) |
Use workspace.default-members to specify default crates for cargo build … and 'cargo test', etc. Include Servo and its unit tests, but not Stylo because that would try to compile the style crate with incompatible feature flags: rust-lang/cargo#4463 `workspace.default-members` was added in rust-lang/cargo#4743. Older Cargo versions ignore it. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19476) <!-- Reviewable:end -->
|
|
I also get this when running |
This will allow writing `tests/unit/*` in the root `Cargo.toml` file to designate Servo unit tests.
(if not usefully)
…ild' … and 'cargo test', etc. Include Servo and its unit tests, but not Stylo because that would try to compile the style crate with incompatible feature flags: rust-lang/cargo#4463 `workspace.default-members` was added in rust-lang/cargo#4743. Older Cargo versions ignore it.
|
Added: --- a/python/servo/testing_commands.py
+++ b/python/servo/testing_commands.py
@@ -254,6 +254,9 @@ class MachCommands(CommandBase):
env = self.build_env()
env["RUST_BACKTRACE"] = "1"
+ # Work around https://github.com/rust-lang/cargo/issues/4790
+ del env["RUSTDOCFLAGS"]
+
if "msvc" in host_triple():
# on MSVC, we need some DLLs in the path. They were copied
# in to the servo.exe build dir, so just point PATH to that.Maybe the "server timed out" was flaky network? @bors-servo r=nox |
|
|
Use workspace.default-members to specify default crates for cargo build … and 'cargo test', etc. Include Servo and its unit tests, but not Stylo because that would try to compile the style crate with incompatible feature flags: rust-lang/cargo#4463 `workspace.default-members` was added in rust-lang/cargo#4743. Older Cargo versions ignore it. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19476) <!-- Reviewable:end -->
|
|
mach: Fix cargo-geckolib check / cargo-geckolib build after #19476. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19539) <!-- Reviewable:end -->
mach: Fix cargo-geckolib check / cargo-geckolib build after #19476. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19539) <!-- Reviewable:end -->
mach: Fix cargo-geckolib check / cargo-geckolib build after #19476. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19539) <!-- Reviewable:end -->
mach: Fix cargo-geckolib check / cargo-geckolib build after #19476. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19539) <!-- Reviewable:end -->
SimonSapin commentedDec 4, 2017
•
edited
… and 'cargo test', etc. Include Servo and its unit tests, but not Stylo because that would try to compile the style crate with incompatible feature flags: rust-lang/cargo#4463
workspace.default-memberswas added in rust-lang/cargo#4743. Older Cargo versions ignore it.This change is